fix(ext/web): remove QuotaExceededError from DOMException error names table#32151
Open
shtse8 wants to merge 1 commit intodenoland:mainfrom
Open
fix(ext/web): remove QuotaExceededError from DOMException error names table#32151shtse8 wants to merge 1 commit intodenoland:mainfrom
shtse8 wants to merge 1 commit intodenoland:mainfrom
Conversation
… table Per whatwg/webidl#1465, QuotaExceededError has been updated from a legacy DOMException name to a proper DOMException subclass. As the minimal change, this removes QuotaExceededError from the error names table so that `new DOMException('msg', 'QuotaExceededError').code` returns 0 instead of 22, aligning with the updated spec. Fixes denoland#30028
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per whatwg/webidl#1465,
QuotaExceededErrorhas been updated from a legacy DOMException name to a proper DOMException subclass. This PR implements the minimal change: removingQuotaExceededErrorfrom the error names table so that its.codereturns0instead of22, aligning with the updated WebIDL spec.Changes
QuotaExceededErrorentry fromnameToCodeMappinginext/web/01_dom_exception.jsnew DOMException('msg', 'QuotaExceededError').code === 0Testing
Added a test in
tests/unit/dom_exception_test.tsthat asserts the new behavior.Fixes #30028