BREAKING(cli/unstable): remove ProgressBarFormatter.styledTime and use DurationFormat

[timreichen]

We should not provide an opinionated time style in the ProgressBarFormatter object, we already provide a defaultFormatter which styles the time.
Instead we should point to Intl.DurationFormat which allows for all kinds of styles.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (3d44532) to head (6ddd319).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6692      +/-   ##
==========================================
- Coverage   94.70%   94.68%   -0.02%     
==========================================
  Files         567      567              
  Lines       46793    46797       +4     
  Branches     6582     6582              
==========================================
- Hits        44315    44312       -3     
- Misses       2436     2443       +7     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kt3k]

We should not provide an opinionated time style in the ProgressBarFormatter object, we already provide a defaultFormatter which styles the time.

I don't see this reasoning. MM:SS is probably most common format for indicating minutes and seconds, and styledTime is convenient shorthand for reusing that format when choosing different style as default formatter. Why do we need to remove it?

[BlackAsLight]

This change doesn't format correctly. It puts everything under the seconds section.

new Intl.DurationFormat(undefined, {
  minutes: "2-digit",
  seconds:"2-digit",
  fractionalDigits: 0
})
  .format({milliseconds: Date.now()});
// "00:1748597655"

[timreichen]

This change doesn't format correctly. It puts everything under the seconds section.

new Intl.DurationFormat(undefined, {
  minutes: "2-digit",
  seconds:"2-digit",
  fractionalDigits: 0
})
  .format({milliseconds: Date.now()});
// "00:1748597655"

Good catch!
I think this has to wait until Temporal is stable. Then that can be solved with Temporal.Duration.prototype.round().
Putting this as draft for now.

[bartlomieju]

Temporal is now stable, do you want to give it another go @timreichen?

[timreichen]

Temporal is now stable, do you want to give it another go @timreichen?

I am a bit busy atm. I might have time for another go on this in a few weeks.

If someone wants to take over feel free.