feat(front-matter/unstable): add test to each subpackage, including JSON, TOML, and YAML#7059
Open
uynilo9 wants to merge 7 commits intodenoland:mainfrom
Open
feat(front-matter/unstable): add test to each subpackage, including JSON, TOML, and YAML#7059uynilo9 wants to merge 7 commits intodenoland:mainfrom
test to each subpackage, including JSON, TOML, and YAML#7059uynilo9 wants to merge 7 commits intodenoland:mainfrom
Conversation
…JSON, TOML, and YAML
test to each subpackage, including JSON, TOML, and YAMLtest to each subpackage, including JSON, TOML, and YAML
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7059 +/- ##
=======================================
Coverage 94.38% 94.38%
=======================================
Files 628 630 +2
Lines 50175 50190 +15
Branches 8840 8840
=======================================
+ Hits 47357 47372 +15
Misses 2251 2251
Partials 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
reviewed
Mar 25, 2026
Member
bartlomieju
left a comment
There was a problem hiding this comment.
A few things to address:
unstable_json.tsandunstable_toml.tsduplicateextract()from the stablejson.tsandtoml.ts. These files should only contain the newtest()function — either re-exportextractfrom the stable module or just don't include it.- The JSON test cases use TOML syntax (
name = 'deno') as the front matter body. Sincetest()only validates delimiters this passes, but it's confusing — please use actual JSON content. - Import style is inconsistent:
json_test.tsuses the@std/front-matter/unstable-jsonspecifier whiletoml_test.tsuses a relative./unstable_toml.tspath. Please use one style consistently.
Author
|
Thanks for reviewing. I didn't realise some absurd mistakes I made since I've been little busy these days.
About the second thing you mention, I use the example directly from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let people use the
testfunction more easily when they want to check a specific format of frontmatter.