BREAKING(cache/unstable): remove re-export in LruCache#7071
Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Open
BREAKING(cache/unstable): remove re-export in LruCache#7071tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
LruCache#7071tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7071 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 630 630
Lines 50486 50486
Branches 8946 8946
=======================================
Hits 47666 47666
Misses 2249 2249
Partials 571 571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LruCache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoizationCacheis defined in and documented as part of@std/cache/memoize. The re-export from@std/cache/lru-cachewas maybe done as a convenience, but should be cleaned up:MemoizationCacheis available from its own path (@std/cache/memoize) and the barrel (@std/cache)ttl_cache.tsalso imports the same type but does not re-export it, creating an asymmetry.lru-cache.tsshould export only LRU-specific symbols.