Skip to content

Bun: Upgrade to Node JS 24#14964

Merged
v-HaripriyaC merged 1 commit into
dependabot:mainfrom
yeikel:patch-23
May 21, 2026
Merged

Bun: Upgrade to Node JS 24#14964
v-HaripriyaC merged 1 commit into
dependabot:mainfrom
yeikel:patch-23

Conversation

@yeikel
Copy link
Copy Markdown
Contributor

@yeikel yeikel commented May 10, 2026

What are you trying to accomplish?

Upgrade NodeJS to 24 for Bun as Node 20 reached end of life on April 30, 2026.

Anything you want to highlight for special attention from reviewers?

This unblocks #14963 for the bun ecosystem

How will you know you've accomplished your goal?

The build passes and all the existing tests continue to work

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@yeikel yeikel mentioned this pull request May 10, 2026
5 tasks
@yeikel yeikel changed the title Upgrade to Node JS 24 Bun: Upgrade to Node JS 24 May 10, 2026
@yeikel yeikel marked this pull request as ready for review May 10, 2026 06:02
@yeikel yeikel requested a review from a team as a code owner May 10, 2026 06:02
v-HaripriyaC
v-HaripriyaC previously approved these changes May 12, 2026
Copy link
Copy Markdown
Contributor

@v-HaripriyaC v-HaripriyaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ: @yeikel , this does not unblock the PR: #14963, I am hoping there are more PRs to unblock this PR?

@yeikel
Copy link
Copy Markdown
Contributor Author

yeikel commented May 12, 2026

QQ: @yeikel , this does not unblock the PR: #14963, I am hoping there are more PRs to unblock this PR?

It unblocks #14963 specifically for the Bun ecosystem because Nodejs 20 is no longer published on that version of Ubuntu. It does not unblock it in general if that's what you meant. For that, there is still other work that needs to be completed

As soon as #14963 is ready, I'll move it back to ready

Thanks for helping!

@yeikel
Copy link
Copy Markdown
Contributor Author

yeikel commented May 13, 2026

@v-HaripriyaC I see you dismissed your review. Could you please clarify if anything else is not clear? Thanks!

@v-HaripriyaC
Copy link
Copy Markdown
Contributor

@yeikel please see my comment above

@yeikel
Copy link
Copy Markdown
Contributor Author

yeikel commented May 15, 2026

@yeikel please see my comment above

Did you see my response: #14964 (comment)

It does not fully unblock #14963 for all ecosystems but it does unblock it for bun

The reason #14963 cannot proceed is that Node JS 20 is no longer maintained and there is no Ubuntu 26 build for it

@v-HaripriyaC
Copy link
Copy Markdown
Contributor

Thanks for the clarification, @yeikel. I understand now that this PR unblocks #14963 specifically for the Bun ecosystem, not more broadly. The change itself looks straightforward and low risk. I’ll hold off on final approval until you move this PR back to Ready for review.

@yeikel
Copy link
Copy Markdown
Contributor Author

yeikel commented May 15, 2026

Thanks for the clarification, @yeikel. I understand now that this PR unblocks #14963 specifically for the Bun ecosystem, not more broadly. The change itself looks straightforward and low risk. I’ll hold off on final approval until you move this PR back to Ready for review.

Thank you. This change (#14964) is already ready for review. It is #14963 what is pending

v-HaripriyaC
v-HaripriyaC previously approved these changes May 19, 2026
Copy link
Copy Markdown
Contributor

@v-HaripriyaC v-HaripriyaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v-HaripriyaC v-HaripriyaC dismissed their stale review May 19, 2026 19:56

CI is green, which is great. Can we also confirm Bun-specific compatibility with Node 24 — especially image build success and a few representative Bun update/integration scenarios — to rule out runtime regressions from the Node 20 → 24 bump?

@yeikel
Copy link
Copy Markdown
Contributor Author

yeikel commented May 20, 2026

CI is green, which is great. Can we also confirm Bun-specific compatibility with Node 24 — especially image build success and a few representative Bun update/integration scenarios — to rule out runtime regressions from the Node 20 → 24 bump?

Bun itself a an standalone binary that does not depend on NodeJS. The reason Node is defined in this ecosystem is because of the native helpers.

The build is already running a lot of integration tests plus unit tests for the helpers. Can you clarify what else are you looking for?

Thanks

@v-HaripriyaC
Copy link
Copy Markdown
Contributor

v-HaripriyaC commented May 21, 2026

I am able to check the relevant jobs/tests, thanks for being patient.

@v-HaripriyaC
Copy link
Copy Markdown
Contributor

Workflow/job files

.github/workflows/ci.yml — ci (bun, bun, bun), integration, Updater, Lint, Rakefile Tests
.github/workflows/images-branch.yml — push-updater-images (includes bun), approval
.github/workflows/ci-arm64.yml — arm64-build (bundler-only, not Bun-specific)
Bun spec files

bun/spec/dependabot/bun/file_fetcher_spec.rb
bun/spec/dependabot/bun/file_updater_spec.rb
bun/spec/dependabot/bun/update_checker_spec.rb
bun/spec/dependabot/bun/update_checker/subdependency_version_resolver_spec.rb

Copy link
Copy Markdown
Contributor

@v-HaripriyaC v-HaripriyaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving now

Node 20 reached end of life on April 30, 2026
@v-HaripriyaC v-HaripriyaC merged commit e9a295e into dependabot:main May 21, 2026
56 checks passed
@yeikel yeikel deleted the patch-23 branch May 21, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants