raise generic error without path information#15088
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces telemetry cardinality for NuGet SDK project dependency discovery failures by ensuring the thrown exception no longer includes a randomly generated temporary binlog path when the binlog is missing.
Changes:
- Adds an explicit
File.Exists(binLogPath)check after MSBuild execution. - Throws a
FileNotFoundExceptionwith a stable, generic message when the binlog was not produced, avoiding path-specific exception details.
Show a summary per file
| File | Description |
|---|---|
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/SdkProjectDiscovery.cs |
Detects missing MSBuild binlog and throws a stable exception message to improve telemetry bucketing. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
sebasgomez238
approved these changes
May 21, 2026
brettfo
force-pushed
the
dev/brettfo/nuget-missing-log
branch
from
d84cd08 to
98d1729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SDK dependency discovery fails to produce a log file we get a
FileNotFoundExceptionat runtime but that exception also contains the missing filename which is randomly generated in temp. Because of this, our telemetry generates a new error event for every one which makes it difficult to analyze how prevalent this error actually is. This PR raises a more generic exception so all like errors can be bucketed together.