add common pattern for directory specification#15108
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes NuGet updater global.json discovery when a job’s directories list includes the common root pattern "/.", ensuring SDK versions can still be detected and installed correctly (addressing #15083).
Changes:
- Normalize update-directory patterns so
"/."(which becomes"."after trimming) is treated as the repository root. - Add a regression test case covering
directories: ["/."]forglobal.jsondiscovery.
Show a summary per file
| File | Description |
|---|---|
nuget/updater/common.ps1 |
Treats "." directory pattern as root to ensure directory regex matches repo root during global.json discovery. |
nuget/updater/test.ps1 |
Adds coverage for the "/." root-directory pattern to prevent regressions. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
jpinz
approved these changes
May 21, 2026
brettfo
force-pushed
the
dev/brettfo/nuget-scan-global-json
branch
from
4a38838 to
b1d4aeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently the discovery of
global.jsonfiles was updated but I missed a common pattern of the job file listing"/.". The fix is simply to account for this in the pattern builder.Fixes #15083