NuGet: Add circular dependency detection to MSBuildHelper.ThrowOnError#15116
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds NuGet/MSBuild output parsing for circular dependency failures so they surface as a stable, standardized exception message (improving telemetry grouping), with a corresponding test case.
Changes:
- Add
ThrowOnCircularDependencyto detect MSBuild output matchingCircular dependency detected '...'and throwException("Circular dependency detected"). - Wire the new detection into
MSBuildHelper.ThrowOnError. - Add a test case validating the new pattern-to-error mapping.
Show a summary per file
| File | Description |
|---|---|
| nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs | Detect circular dependency output and throw a standardized exception via ThrowOnError. |
| nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/MSBuildHelperTests.cs | Adds coverage ensuring circular dependency output becomes an unknown_error with the standardized message. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
VXianOng
approved these changes
May 22, 2026
Add a new ThrowOnCircularDependency helper that matches the pattern 'Circular dependency detected ''..''' in MSBuild output and throws a plain Exception with the message 'Circular dependency detected' to enable proper grouping in telemetry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
brettfo
force-pushed
the
dev/brettfo/nuget-circular-dep-error
branch
from
13e33af to
8edf1af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new ThrowOnCircularDependency helper that matches the pattern 'Circular dependency detected ...' in MSBuild output and throws a plain Exception with the message 'Circular dependency detected' to enable proper grouping in telemetry.
Changes