Revert "Add API integration to fetch blocked versions at job construction"#15120
Merged
robaiken merged 1 commit intoMay 22, 2026
Merged
Conversation
kbukum1
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously added updater-side API integration that fetched “blocked versions” during job construction, returning job creation to using the raw Environment.job_definition and removing the corresponding API client surface area/spec coverage.
Changes:
- Remove job-construction-time
fetch_blocked_versionsbehavior fromUpdateFilesCommandand drop theApiClient#fetch_blocked_versionsimplementation/specs. - Update blocked-versions payload shape in the updater to use
"version"(instead of"version-requirement") and adjust specs/dry-run output accordingly. - Remove
Servicedelegation and specs tied to the removed blocked-versions API call.
Show a summary per file
| File | Description |
|---|---|
| updater/lib/dependabot/update_files_command.rb | Reverts job construction to use Environment.job_definition without blocked-versions API injection. |
| updater/lib/dependabot/api_client.rb | Removes the fetch_blocked_versions API call implementation. |
| updater/lib/dependabot/service.rb | Removes delegation of fetch_blocked_versions to the client. |
| updater/lib/dependabot/job.rb | Switches blocked-versions entry parsing/logging to use "version" key. |
| updater/spec/dependabot/update_files_command_spec.rb | Removes specs for blocked-versions injection at job construction. |
| updater/spec/dependabot/api_client_spec.rb | Removes specs for fetch_blocked_versions. |
| updater/spec/dependabot/job_spec.rb | Updates blocked-versions specs to the "version" key. |
| bin/dry-run.rb | Updates blocked-versions env example/output and filtering to use "version". |
Copilot's findings
- Files reviewed: 7/8 changed files
- Comments generated: 1
Comment on lines
492
to
496
| def blocked_versions_for(dependency) | ||
| matching_blocked_entries(dependency).filter_map do |bv| | ||
| req = bv["version-requirement"].strip | ||
| req.empty? ? nil : req | ||
| version = bv["version"].strip | ||
| version.empty? ? nil : version | ||
| end |
robaiken
deleted the
revert-14917-kbukum1/add-blocked-versions-api-integration
branch
kbukum1
restored the
revert-14917-kbukum1/add-blocked-versions-api-integration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #14917