Skip Gradle cooldown metadata fetch when cooldown is not configured#15136
Open
yeikel wants to merge 1 commit into
Open
Skip Gradle cooldown metadata fetch when cooldown is not configured#15136yeikel wants to merge 1 commit into
yeikel wants to merge 1 commit into
Conversation
Avoids unnecessary network requests to fetch release-date metadata on every Gradle job when the user has no cooldown configured (the default). Fixes dependabot#14152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Avoids unnecessary network requests to fetch release-date metadata on every Gradle job when the user has no cooldown configured (the default).
Fixes #14152
Anything you want to highlight for special attention from reviewers?
As described in #14152, fetching this metadata by default when
cooldownis not configured is wastefulHow will you know you've accomplished your goal?
CLI tests:
Reproducer: https://github.com/yeikel/dependabot-reproducer-issue-15136
Before:
After:
Checklist