[jeffwidman]

What are you trying to accomplish?

Remove the unused max-updater-run-time job field from updater fixtures and the NuGet job model.

The Ruby updater already discards this field when constructing a job, and the NuGet property was optional and had no readers. Removing it keeps fixtures and models aligned with the job contract without changing updater behavior.

Anything you want to highlight for special attention from reviewers?

The field is safe to remove independently: Ruby ignores it, and NuGet job deserialization accepts both a missing property and unknown properties.

How will you know you've accomplished your goal?

Validated with:

• The focused updater operation spec: 2 examples, 0 failures
• NuGet serialization tests: 55 passed, 0 failed
• An exact repository search confirming no max-updater-run-time, max_updater_run_time, or MaxUpdaterRunTime references remain

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

Related:

• Remove unused updater timeout fixture github/dependabot-action#1756

[Copilot]

Pull request overview

Removes the unused updater timeout field from job fixtures and the NuGet API model without changing runtime behavior.

Changes:

• Removed max-updater-run-time from updater fixtures and expectations.
• Removed the unused NuGet MaxUpdaterRunTime property.
• Updated NuGet serialization coverage.

Show a summary per file

File	Description
updater/spec/fixtures/job_definitions/dummy/version_updates/group_update_peer_manifests.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/pull_request_simple.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_versions_changed.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_similar_pr.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_multiple_groups_unchaged.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_multiple_groups_unchaged_second_group.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_missing_group.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_empty_group.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/group_update_refresh_dependencies_changed.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/allow_update_types_patch_only.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/version_updates/allow_update_types_minor_and_patch.yaml	Removes obsolete timeout field.
updater/spec/fixtures/job_definitions/bundler/security_updates/group_update_multi_dir.yaml	Removes obsolete timeout field.
updater/spec/dependabot/updater/operations/refresh_group_update_pull_request_multi_dir_spec.rb	Aligns expected job input with the supported contract.
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/ApiModel/Job.cs	Removes the unread timeout property.
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Run/SerializationTests.cs	Updates serialization input for the revised model.

Review details

Tip

Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 16/16 changed files
• Comments generated: 0
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 16/16 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 16/16 changed files
• Comments generated: 0 new
• Review effort level: Balanced