Skip to content

Allow dotnetcli.blob.core.windows.net for .NET release metadata #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johanm76 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow dotnetcli.blob.core.windows.net for .NET release metadata #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,11 @@ ecosystem_default_domains:
# Official Microsoft .NET SDK/runtime build hosts.
- builds.dotnet.microsoft.com
- ci.dot.net
# .NET release metadata index (releases-index.json), served from Microsoft's
# production Azure Blob storage (documented in dotnet/core). Exact host: the
# "dotnetcli" account is globally unique and Microsoft-owned, so it cannot be
# spoofed.
- dotnetcli.blob.core.windows.net
hex:
- repo.hex.pm
- hex.pm
Expand Down
2 changes: 2 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,7 @@ func TestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts(t *testing.T) {
"https://evil.julialang-s3.julialang.org/bin",
"https://evil.maven.artifacts.atlassian.com/maven",
"https://evil.mirrors.huaweicloud.com/repository/npm",
"https://evil.dotnetcli.blob.core.windows.net/payload",
}

// Sibling hosts: names sharing a parent with an added entry. These pin the
Expand Down Expand Up @@ -901,6 +902,7 @@ func TestEgressAllowlist_AddedMissingDomainsAllowed(t *testing.T) {
"https://repo.broadcom.com/artifactory/repo",
"https://builds.dotnet.microsoft.com/dotnet/Sdk/x.zip",
"https://ci.dot.net/public/dotnet/x.nupkg",
"https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json",
"https://charts.bitnami.com/bitnami/index.yaml",
"https://charts.jetstack.io/charts/cert-manager.tgz",
"https://prometheus-community.github.io/helm-charts/index.yaml",
Expand Down
Loading