Skip to content

Allowlist nvcr.io for docker update jobs #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v-robaiken merged 1 commit into from
Oct 12, 2026
Merged

Allowlist nvcr.io for docker update jobs #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,15 @@ ecosystem_default_domains:
# the Kubernetes release infrastructure, so no subdomain is user-creatable.
# The `k8s.io` entry in go_modules is exact and does not cover this host.
- registry.k8s.io
# NVIDIA NGC container registry. Public NGC images need no sign-in: /v2/
# advertises a Bearer realm on the same host (nvcr.io/proxy_auth), which
# issues a guest token with pull access to public repositories only. Blobs
# 307-redirect to layers.nvcr.io, NVIDIA's CloudFront distribution, which
# serves only URLs signed by nvcr.io and 403s unsigned requests. Exact only:
# tenancy is path-based (nvcr.io/<org>/<team>/<image>), and private org
# images still need an NGC API key under `registries:`.
- nvcr.io
- layers.nvcr.io
docker_compose: *docker_registries
nuget:
- api.nuget.org
Expand Down
8 changes: 8 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ func TestEgressAllowlist_PublicVendorOCIRegistriesAllowed(t *testing.T) {
"https://registry.k8s.io/v2/coredns/coredns/manifests/v1.14.7",
"https://registry.k8s.io/token?scope=repository:coredns/coredns:pull&service=registry.k8s.io",
"https://europe-west8-docker.pkg.dev/v2/k8s-artifacts-prod/images/coredns/coredns/tags/list",
// NVIDIA NGC: same-host guest token service, and blobs 307-redirect to
// NVIDIA's signed-URL CloudFront host.
"https://nvcr.io/v2/nvidia/cuda/tags/list",
"https://nvcr.io/v2/nvidia/distroless/go/manifests/v4.1.4",
"https://nvcr.io/proxy_auth?account&scope=repository:nvidia/cuda:pull&service=registry",
"https://layers.nvcr.io/registry/docker/registry/v2/blobs/sha256/ab/abc/data",
} {
assert.Nil(t, egressResult(t, h, allowed), "public vendor OCI host allowed: "+allowed)
}
Expand All @@ -282,6 +288,8 @@ func TestEgressAllowlist_PublicVendorOCIRegistriesAllowed(t *testing.T) {
"https://evil.cgr.dev/v2/",
"https://evil.registry.access.redhat.com/v2/",
"https://evil.registry.k8s.io/v2/",
"https://evil.nvcr.io/v2/",
"https://evil.layers.nvcr.io/registry/",
// The Go vanity-import entry for k8s.io is exact, so the apex and its
// other subdomains stay closed even with registry.k8s.io allowed.
"https://attacker.k8s.io/v2/",
Expand Down
Loading