Repository navigation
Allowlist prelude-public.s3.amazonaws.com for Swift binary targets - #305
Merged
v-robaiken merged 1 commit intoOct 12, 2026
Merged
Conversation
The Prelude Apple SDK declares its PreludeCore binaryTarget on this S3 bucket. SwiftPM resolves it while Dependabot parses the manifest, so the block fails every Swift update job for repos that depend on the SDK. Fixes dependabot#304
v-robaiken
approved these changes
Oct 12, 2026
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Hosted Dependabot
swiftversion updates fail for any repo depending on the Prelude Apple SDK sinceproxy-egress-enforcewas enabled. The SDK declares itsPreludeCoreSwiftPMbinaryTargetonhttps://prelude-public.s3.amazonaws.com/...(Package.swift), and the allowlist 403s that host:SwiftPM resolves the whole package graph during manifest parsing, so the job dies in
Dependabot::Swift::FileParserand no Swift PRs are opened at all. Ignoring the dependency independabot.ymldoesn't help.The bucket is Prelude's public SDK distribution bucket, referenced from the vendor's own public
Package.swift, and serves anonymously, so there is no credential to declare underregistries:.This adds
prelude-public.s3.amazonaws.comas an exact host toecosystem_default_domains.swift.Fixes #304
Anything you want to highlight for special attention from reviewers?
One exact entry closes the chain. The artifact path from the report, probed with
--max-redirs 0, returns206 application/zipwith noredirect_url. All resolved addresses are public AWS S3 (eu-west-1) IPs.Exact virtual-hosted bucket, deliberately. This follows the existing
a8c-libs.s3.amazonaws.comprecedent: one already-registered bucket, never a glob over shared S3 and never the path-styles3.amazonaws.comapex. The certificate is AWS's own (CN=*.s3-eu-west-1.amazonaws.com, issued by Amazon), so ownership evidence is the vendor's public manifest naming the bucket, not the cert.Why not
registries:. The host is anonymous. Declaring it as a credential just to allowlist it would attach anAuthorizationheader to a public S3 download.swiftis not an anchor/alias member, so no aliased ecosystem needs the same edit. Precedent for the section: #290 / #298 (sdk.karte.io).How will you know you've accomplished your goal?
Reproduction is in #304 (proxy
20763b1, 2026-10-08): thePreludeCorerequest returns403under enforcement and the Swift job fails, while other binary targets in the same job (dl.google.com, GitHub release assets) succeed.Coverage in
TestEgressAllowlist_PublicVendorRegistriesAllowed:https://evil.prelude-public.s3.amazonaws.com/payload. I confirmed it bites by temporarily changing the entry to.prelude-public.s3.amazonaws.com; the test failed withmust stay blocked: https://evil.prelude-public.s3.amazonaws.com/payload, then I reverted.https://prelude-public-attacker.s3.amazonaws.com/payload.https://s3.amazonaws.com/prelude-public/payload.Ran locally with Go 1.26.8:
go build ./...,go test ./internal/handlers/ -run TestEgress -count=1,gofmt -l internal/handlers/(empty) andgo test -race -count=2 ./...(all packages pass). Docker wasn't available, soscript/testitself wasn't run; that box is left unticked.Checklist