Repository navigation
Allowlist public Helm chart repositories (Datadog, HashiCorp, Teleport, Wiz, Fluent) - #318
Conversation
…t, Wiz, Fluent) Adds exact entries for helm.datadoghq.com, helm.releases.hashicorp.com, charts.releases.teleport.dev, charts.wiz.io, wiz-sec.github.io (Wiz chart tarballs) and fluent.github.io, with positive and child-host regression probes. Refs dependabot#314.
There was a problem hiding this comment.
🟡 Changes recommended
Four new parent namespaces lack the sibling probes required by the test contract.
1 open finding
What changed in this PR
Adds six public Helm repository hosts to the global egress allowlist.
Changes:
- Adds exact vendor-controlled Helm hosts.
- Adds positive and child-subdomain regression probes.
| File | Description |
|---|---|
internal/handlers/egress_allowlist_defaults.yaml |
Adds Helm repository domains. |
internal/handlers/egress_allowlist_test.go |
Tests allowed URLs and exact-host boundaries. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@v-robaiken thanks for approving/merging this! Just curious - at what point does the update allowlist become live? I'm still seeing the proxy blocking requests to hosts that were added here as of today. We're using EDIT: I see our jobs are running proxy commit |
@bkonicek-calm that is correct. I will bump the version now and ping you when it's done. |
|
@bkonicek-calm This change is now live |
|
Thanks, confirmed this is working for us now! |

What are you trying to accomplish?
Fixes #314. Helm chart repositories that are public, vendor-controlled infrastructure are blocked by the egress allowlist (
egress not allowlisted <host>/ 403). This adds them as exact entries underecosystem_default_domains.helm:charts.releases.teleport.devhelm.releases.teleport.dev,index.yamlreturns 200charts.wiz.ioindex.yamlwiz-sec.github.io, valid certificate,index.yamlreturns 200wiz-sec.github.iocharts.wiz.ioCNAMEfluent.github.iogithub.com, already allowed)index.yamlreturns 200helm.datadoghq.comgithub.com)datadog.github.io, valid certificate,index.yamlreturns 200helm.releases.hashicorp.comCN=helm.releases.hashicorp.com,index.yamlreturns 200helm.datadoghq.comandhelm.releases.hashicorp.comwere not in the issue but are the same class of public chart repo.Anything you want to highlight for special attention from reviewers?
*.github.io.wiz-sec.github.iois included because Wiz's index references tarballs there; allowing onlycharts.wiz.iowould still block downloads.How will you know you've accomplished your goal?
TestEgressAllowlist_AddedMissingDomainsAllowedand anevil.<host>child probe inTestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts, which fails if an entry is widened to leading-dot form (verified forhelm.datadoghq.com).go test ./...passes locally.go test -race -shuffle=on -count=2 ./...passes in thebuilder-testsDocker image.script/testitself fails on an Apple Silicon host withgo: -race requires cgobecause the Dockerfile pinsGOARCH=amd64, so I ran the same command with-e GOARCH=arm64.Checklist