Skip to content

Allow Proton's public sparse Cargo registry in egress allowlist #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcmy wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Allow Proton's public sparse Cargo registry in egress allowlist #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,8 @@ ecosystem_default_domains:
- static.crates.io
- index.crates.io
- rsproxy.cn
# Proton AG's public sparse Cargo registry (pvpnclient, muon).
- rust-registry.proton.me
composer:
- repo.packagist.org
- packagist.org
Expand Down
2 changes: 2 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ func TestEgressAllowlist_PublicRegistriesAllowed(t *testing.T) {
"https://go.googlesource.com/tools",
"https://android.googlesource.com/platform",
"https://nodejs.org/dist/index.json",
"https://rust-registry.proton.me/index/config.json",
"https://adsbynimbus-public.s3.amazonaws.com/android/sdks",
} {
assert.Nil(t, egressResult(t, h, allowed), "public registry host allowed: "+allowed)
Expand Down Expand Up @@ -717,6 +718,7 @@ func TestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts(t *testing.T) {
// moment its entry is changed to a leading-dot suffix, so this is the probe
// set that actually pins exact-host semantics.
childProbes := []string{
"https://evil.rust-registry.proton.me/payload",
"https://evil.docker.redpanda.com/payload",
"https://evil.appboy.github.io/payload",
"https://evil.juliaregistries.github.io/payload",
Expand Down
Loading