Skip to content

Allowlist download.onnxruntime.ai for Swift binary targets #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wcy41gtc wants to merge 1 commit into from
Closed

Allowlist download.onnxruntime.ai for Swift binary targets #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/handlers/egress_allowlist_defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,5 +684,10 @@ ecosystem_default_domains:
# (RealSprint/vindral-apple-sdk-spm). Anonymous, no redirect.
# Exact: *.vindral.com also fronts the vendor's CDN and stage/test hosts.
- applesdk.vindral.com
# Microsoft's ONNX Runtime release host, serving the onnxruntime and
# onnxruntime_extensions zip binaryTargets declared in the vendor's own
# public Package.swift (microsoft/onnxruntime-swift-package-manager).
# Anonymous, no redirect. Exact: the certificate names only this host.
- download.onnxruntime.ai
vcpkg: []
pre_commit: []
8 changes: 8 additions & 0 deletions internal/handlers/egress_allowlist_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,9 @@ func TestEgressAllowlist_PublicVendorRegistriesAllowed(t *testing.T) {
"https://sf16-fe-tos-sg.i18n-pglstatp.com/obj/pangle-sdk-static-va/8.3.0.8/TikTokBusinessSDK.xcframework.zip",
// Same failure mode for the Vindral Apple SDK's VindralStreaming binaryTarget.
"https://applesdk.vindral.com/tag/1.2.0/VindralStreaming.zip",
// Same failure mode for ONNX Runtime's onnxruntime and onnxruntime_extensions binaryTargets.
"https://download.onnxruntime.ai/pod-archive-onnxruntime-c-1.24.2.zip",
"https://download.onnxruntime.ai/pod-archive-onnxruntime-extensions-c-0.13.0.zip",
} {
assert.Nil(t, egressResult(t, h, allowed), "public vendor registry allowed: "+allowed)
}
Expand Down Expand Up @@ -1333,6 +1336,11 @@ func TestEgressAllowlist_PublicVendorRegistriesAllowed(t *testing.T) {
"https://evil.applesdk.vindral.com/payload",
"https://attacker.vindral.com/payload",
"https://vindral.com/payload",
// The ONNX Runtime release host is one exact host: no children, and
// never the project's parent domain or its other subdomains.
"https://evil.download.onnxruntime.ai/payload",
"https://attacker.onnxruntime.ai/payload",
"https://onnxruntime.ai/payload",
} {
resp := egressResult(t, h, blocked)
if assert.NotNil(t, resp, "must stay blocked: "+blocked) {
Expand Down
Loading