Skip to content

feat: [GRWT-6650] Handle signupCode in social auth for country selection #997

Open
aliakbar-deriv wants to merge 5 commits into
deriv-com:masterfrom
aliakbar-deriv:aliakbar/GRWT-6650-social-login-country-selection-by-user
Open

feat: [GRWT-6650] Handle signupCode in social auth for country selection #997
aliakbar-deriv wants to merge 5 commits into
deriv-com:masterfrom
aliakbar-deriv:aliakbar/GRWT-6650-social-login-country-selection-by-user

Conversation

@aliakbar-deriv

@aliakbar-deriv aliakbar-deriv commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

Clickup link: https://app.clickup.com/t/20696747/GRWT-6650

This PR contains the following changes:

  • Add AuthErrorType.socialSignupIncomplete for signupCode scenarios

  • Add SOCIAL_SIGNUP_INCOMPLETE error constant

  • Throw exception when signupCode present in social signup response

  • Enable country selection flow for incomplete social signups

  • ✨ New feature (non-breaking change which adds functionality)

  • 🛠️ Bug fix (non-breaking change which fixes an issue)

  • ❌ Breaking change (fix or feature that would cause existing functionality to change)

  • 🧹 Code refactor

  • ✅ Build configuration change

  • 📝 Documentation

  • 🗑️ Chore

Developers Note (Optional)

Pre-launch Checklist (For PR creator)

As a creator of this PR:

  • ✍️ I have included clickup id and package/app_name in the PR title.
  • 👁️ I have gone through the code and removed any temporary changes (commented lines, prints, debug statements etc.).
  • ⚒️ I have fixed any errors/warnings shown by the analyzer/linter.
  • 📝 I have added documentation, comments and logging wherever required.
  • 🧪 I have added necessary tests for these changes.
  • 🔎 I have ensured all existing tests are passing.

Reviewers

Pre-launch Checklist (For Reviewers)

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

- Add AuthErrorType.socialSignupIncomplete for signupCode scenarios
- Add SOCIAL_SIGNUP_INCOMPLETE error constant
- Throw exception when signupCode present in social signup response
- Enable country selection flow for incomplete social signups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants