support for generating es6 imports and .d.ts files#1
Open
Conversation
ribrdb
reviewed
Dec 9, 2024
ribrdb
left a comment
ribrdb
left a comment
There was a problem hiding this comment.
could you temporarily add the output of running this on test.proto so I can see the output?
ribrdb
reviewed
Jan 6, 2025
example/test.js
Outdated
| // @ts-nocheck | ||
|
|
||
| import * as jspb from 'google-protobuf'; | ||
| var goog = jspb; |
There was a problem hiding this comment.
This probably wiill need to be something like import { goog } from 'closure-library/goog.js.
But that may be fine to figure out later.
There was a problem hiding this comment.
the correct import for goog is import * as goog from 'closure-library/closure/goog';
We still need to figure out how the jspb stuff should be imported.
ribrdb
reviewed
Jun 3, 2025
ribrdb
reviewed
Jul 23, 2025
lukfugl
commented
Jul 28, 2025
Don't use class properties
* replace most uses of GetQualifiedMessagePath with either LocalMessageRef (when dealing with a top-level message for the file) or SubmessageTypeRef (when dealing with a message field) * similar for GetQualifiedEnumPath, but MaybeCrossFileEnumPath as the analogue for SubmessageTypeRef * update uses of LocalMessageRef for message fields to SubmessageTypeRef * update most uses of MaybeCrossFileMessageRef to SubmessageTypeRef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on protocolbuffers#150, adding:
libraryoption with ES6generate_dtsflag) and compatible (libraryoption set andimport_styleset toes6)Tested compilation of Derivita's omaha/base/ast.proto and inspecting the generated
omaha/base/ast_proto.jsandomaha/base/ast_proto.d.tsfiles.