Open
Conversation
Owner
|
sorry for the delay -- I've seen your PR, but don't currently have the time to properly review it :-( I will do it though, sooner or later, if that's ok. |
Owner
|
Haha -- apologies! :) I've restarted the CI build, but could you rebase the commit to make sure there are no conflicts? Last time the build failed on Linux, seemingly due to a bad cmake version in Travis or something.. |
Owner
|
OK, I fixed the last Travis error. If you push a rebased version, it will trigger a new build - can you try that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified CMakeList.txt (modified install path, in FreeBSD the external lib and header files are located at /usr/local/lib and /usr/local/header)
Modified libinetsocket.c (fix compat with FreeBSD version of struct ifreq)