Skip to content

Fix the "Failed prop type" warning generated by prop-types' checkProp…#57

Open
janis-github wants to merge 1 commit intoderrickpelletier:masterfrom
janis-github:master
Open

Fix the "Failed prop type" warning generated by prop-types' checkProp…#57
janis-github wants to merge 1 commit intoderrickpelletier:masterfrom
janis-github:master

Conversation

@janis-github
Copy link
Copy Markdown

…Types

raw warning:
Failed prop type: LoadingOverlayWrapper: prop type 'styles.content' is invalid; it must be a function, usually from the 'prop-types' package, but received 'undefined'

fixes the issue: #56

…Types

Warning:
Failed prop type: LoadingOverlayWrapper: prop type 'styles.content' is invalid; it must be a function, usually from the 'prop-types' package, but received 'undefined'
@albeiroespitia
Copy link
Copy Markdown

+1

2 similar comments
@ArekMiszcz
Copy link
Copy Markdown

+1

@dalmau
Copy link
Copy Markdown

dalmau commented Feb 11, 2022

+1

@singleseeker
Copy link
Copy Markdown

Good job , plz merge this pr, @derrickpelletier

@bishnudev01
Copy link
Copy Markdown

please merge this.

@rcapulong
Copy link
Copy Markdown

+1 thanks!

@alexnatea
Copy link
Copy Markdown

I would be very grateful if you merge this resolved issue. Thank you guys!

@johnnyaug
Copy link
Copy Markdown

Thanks!

@janis-github
Copy link
Copy Markdown
Author

Obviously this repo is dead...
Here is a simple one-liner workaround:

import LoadingOverlay from "react-loading-overlay"
LoadingOverlay.propTypes = undefined

@Earthwormzim
Copy link
Copy Markdown

Package "@ronchalant/react-loading-overlay" doesn't appear to have this issue.

@njaniintel
Copy link
Copy Markdown

Please merge this

@0xF217
Copy link
Copy Markdown

0xF217 commented May 21, 2022

Seriously, this repo is dead. move to https://github.com/paypal/react-paypal-js.

Copy link
Copy Markdown

@thirumalesh-ht thirumalesh-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamcarrollsimfy
Copy link
Copy Markdown

Please merge waiting on this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.