Refactor how QuasarNP handles wavelength grids#14
Open
dylanagreen wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I move all wavelength grid definitions to a new class/object called a WaveGrid. The WaveGrid has functionality defining the default logarithmic and linear QuasarNET wavelength grids, as well as a length function for easy interop with extant code.
All internal code now defines these WaveGrid objects, and uses them wherever necessary. This change was mostly motivated by the desire to move all numpy related code out of the top level of the module so that numpy is not a requirement for the documentation (although QuasarNP has already been updated to install numpy when required for the documentation.
Additionally, some doc strings have been updated aside from the WaveGrid change to include text previously accidentally omitted.