Skip to content

Allow post data method modification #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienSol wants to merge 5 commits into
base: master
Choose a base branch
from
+5 −7
Open

Allow post data method modification #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
578e536
Allow post data method modification
JulienSol Jun 3, 2017
feed6da
Fix the parsing of JSON responses
JulienSol Jun 4, 2017
841339a
Fix indentation
JulienSol Jun 4, 2017
cdc3905
Revert "Fix indentation"
JulienSol Jun 5, 2017
8f82488
Revert "Fix the parsing of JSON responses"
JulienSol Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/twitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ function Twitter(options) {
user_stream_base: 'https://userstream.twitter.com/1.1',
site_stream_base: 'https://sitestream.twitter.com/1.1',
media_base: 'https://upload.twitter.com/1.1',
post_method: null,
request_options: {
headers: {
Accept: '*/*',
Expand Down Expand Up @@ -129,14 +130,10 @@ Twitter.prototype.__request = function(method, path, params, callback) {
options.qs = params;
}

// Pass form data if post
// Pass data if post
if (method === 'post') {
var formKey = 'form';

if (typeof params.media !== 'undefined') {
formKey = 'formData';
}
options[formKey] = params;
var post_method = this.options.post_method ? this.options.post_method : (params.media ? 'formData' : 'form');
options[post_method] = params;
}

// Promisified version
Expand Down
1 change: 1 addition & 0 deletions test/twitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe('Twitter', function() {
user_stream_base: 'https://userstream.twitter.com/1.1',
site_stream_base: 'https://sitestream.twitter.com/1.1',
media_base: 'https://upload.twitter.com/1.1',
post_method: null,
request_options: {
headers: {
'Accept': '*/*',
Expand Down