fix: Handle server_notice in audio identification response (#253)#258
Merged
Conversation
BookDB can return server_notice with action=abort_task to signal LM should stop processing. This was handled in search_bookdb() but not in identify_audio_with_bookdb(). Added server_notice handling in three places: the initial submit response, the poll completion response, and the final result data (covers old sync path and acts as catch-all).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server_noticehandling toidentify_audio_with_bookdb()in three locations: the initial submit response, the poll completion response, and the final result datasearch_bookdb()(issue [BUG] watch_folder_processed is in-memory only + add handler for Skaldleita server_notice #208): logs notices, respectsabort_taskaction via thread-local_abort_stateCloses #253
Test plan
python3 test-env/test-naming-issues.py— 290/290 passedruff check . --select=F821— all checks passed