fix: Add nonce to signing protocol to reduce replay window (#256)#262
Merged
Conversation
Promote develop to main after PR #217 and passing CI.
Release 0.9.0-beta.152
- Add generate_nonce() function returning UUID4 hex string - Make nonce optional in generate_signature() and verify_signature() for backwards compatibility with older Skaldleita versions - Update get_signed_headers() in bookdb.py to include X-LM-Nonce - Reduce TIMESTAMP_TOLERANCE from 300s to 120s (2 minutes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-LM-Nonce) — backwards compatible (old BookDB ignores it)Security: Reduces replay attack surface from 5 minutes to 2 minutes, and enables BookDB-side nonce tracking for full replay prevention.
Closes #256
Test plan