Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new token update script currently echoes the secret via input() and has misleading CLI help text, which should be fixed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds operational tooling and preset definitions to support CharmHub token rotation and release automation in kubeflow-ci-cli.
Changes:
- Added a script to guide generating a CharmHub token and updating GitHub environment secrets across repos.
- Added new release preset files for Spark and Kubeflow 1.11.
- Updated the Kubeflow 1.10 release preset to adjust selected tracks/branches (and correct formatting).
File summaries
| File | Description |
|---|---|
| scripts/update-charmhub-token.py | New helper script to update CharmHub token secrets in GitHub environments. |
| presets/release.spark.yaml | New preset listing Spark-related charm repos/branches to target. |
| presets/release-1.11.yaml | New preset listing Kubeflow 1.11 charm repos/branches to target. |
| presets/release-1.10.yaml | Updates branch/track selections for release 1.10 preset. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| logger.info("Building charmcraft command") | ||
|
|
||
| cmd_str = "charmcraft login --quiet " + charms_list + \ | ||
| " --ttl 31536000 " + \ |
There was a problem hiding this comment.
nitpick: Maybe add a small comment to mention this magic number (one year), or a constant on the top of the file, or even better or a configurable ttl
| "--export /dev/stdout" | ||
|
|
||
| print(cmd_str) | ||
| import getpass |
There was a problem hiding this comment.
suggestion(non-blocking): Pass the .py through a linter, because we shouldn't have an import in the middle of the file.
Script to update the charmhub token