fix: Add custom focus styles for form fields#425
Merged
dev-fatima-24 merged 2 commits intoMay 29, 2026
Conversation
- Add CSS variables for focus ring colors (light/dark mode) - Implement box-shadow focus indicators for inputs, textareas, selects - Implement outline focus indicators for buttons - Add readonly input focus handling - Ensure 3:1 contrast ratio (4.5:1 light, 8.2:1 dark) - Never use outline: none without replacement Fixes dev-fatima-24#291
|
@maztah1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #291
Implements custom focus styles for all form elements to ensure consistent, accessible keyboard navigation across browsers.
Changes
--focus-ringand--focus-ring-offsetfor light/dark modeoutline: nonewithout a replacement focus indicatorAcceptance Criteria
✅ All form inputs have custom focus styles
✅ Focus styles meet 3:1 contrast ratio (exceeds: 4.5:1 light, 8.2:1 dark)
✅ Consistent across all form elements (input, select, textarea, button)
✅ Visible in both light and dark modes
✅ Never uses outline: none without replacement
Testing
Press Tab to navigate through form fields on any page with forms (Issuer Dashboard, Verify, Admin, Apply). You'll see consistent blue focus rings on all inputs.