Skip to content

Fix immutable desktop release uploads #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dev-ik merged 1 commit into from
Jun 21, 2026
Merged

Fix immutable desktop release uploads #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/desktop-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,16 +177,17 @@ jobs:
- name: Generate checksums
run: npm run release:checksums -- release-assets

- name: Create or update release
- name: Create release
env:
GH_TOKEN: ${{ github.token }}
run: |
if gh release view "$VERSION" >/dev/null 2>&1; then
gh release upload "$VERSION" release-assets/* --clobber
else
gh release create "$VERSION" \
--verify-tag \
--title "SpecDock $VERSION" \
--notes-file "docs/release-notes/${VERSION}.md" \
release-assets/*
echo "::error title=Release already exists::GitHub immutable releases do not allow replacing assets. Create a new patch tag, for example v1.0.1, and run Desktop Release for that tag."
exit 1
fi

gh release create "$VERSION" \
--verify-tag \
--title "SpecDock $VERSION" \
--notes-file "docs/release-notes/${VERSION}.md" \
release-assets/*
6 changes: 4 additions & 2 deletions docs/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ npm run release:checksums
Publish `apps/desktop/release/desktop/SHA256SUMS.txt` alongside the desktop
downloads so users can verify artifacts.

GitHub-hosted desktop artifacts are published by the `Desktop Release` workflow.
Push an immutable `v*` tag, or run the workflow manually with an existing tag:
GitHub-hosted desktop artifacts are published by the `Desktop Release` workflow
for a new immutable `v*` tag:

```bash
git tag v1.0.0
Expand All @@ -39,6 +39,8 @@ git push origin v1.0.0

The workflow builds macOS, Windows, and Linux artifacts, generates
`SHA256SUMS.txt`, and attaches everything to the matching GitHub Release.
If that release already exists, create a new patch tag instead of replacing
assets on the published release.
Desktop artifacts are unsigned by default for open-source releases. If signing
secrets are configured, macOS and Windows artifacts are signed automatically.

Expand Down