add github secret to deployment#321
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR maps existing GitHub App credentials from the integrations Kubernetes Secret into the Strapi deployment’s environment so the GitHub org invite automation can access them at runtime.
Changes:
- Add
GITHUB_APP_IDenv var sourced fromintegrationssecret keygithub-strapi-invite-new-member-app-id - Add
GITHUB_APP_INSTALLATION_IDenv var sourced fromintegrationssecret keygithub-strapi-invite-new-member-app-installation-id - Add
GITHUB_APP_PRIVATE_KEYenv var sourced fromintegrationssecret keygithub-strapi-invite-new-member-app-private-key
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chungthuang
approved these changes
Apr 19, 2026
Contributor
|
@oriyomibadmus do you know why the build is failing here? cc @chungthuang |
derrickshunhung
force-pushed
the
oriyomibadmus/test-githubautomation
branch
from
4d38e28 to
0f0e2bb
Compare
derrickshunhung
force-pushed
the
oriyomibadmus/test-githubautomation
branch
from
0f0e2bb to
ab4dc5a
Compare
|
chungthuang
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub App credentials (GITHUB_APP_ID, GITHUB_APP_INSTALLATION_ID, GITHUB_APP_PRIVATE_KEY) are defined in the integrations secret in k8s-infra, but were never mapped to environment variables in the deployment spec. As a result, these values were undefined at runtime, causing the GitHub org invite automation to fail silently.