Skip to content

Fixes diagnostics. Closes #215#255

Merged
garrytrinder merged 2 commits into
mainfrom
215-bug-diagnostics-remain-if-a-file-is-deleted
May 22, 2025
Merged

Fixes diagnostics. Closes #215#255
garrytrinder merged 2 commits into
mainfrom
215-bug-diagnostics-remain-if-a-file-is-deleted

Conversation

@garrytrinder

Copy link
Copy Markdown
Member

@garrytrinder garrytrinder linked an issue May 22, 2025 that may be closed by this pull request
@garrytrinder garrytrinder requested a review from Copilot May 22, 2025 23:20
@garrytrinder garrytrinder merged commit ab354f4 into main May 22, 2025
3 checks passed
@garrytrinder garrytrinder deleted the 215-bug-diagnostics-remain-if-a-file-is-deleted branch May 22, 2025 23:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #215 by fixing the diagnostics behavior when files are deleted, along with a version bump to 0.23.3.

  • Adds a listener for file deletion events in src/documents.ts to remove corresponding entries from the collection.
  • Updates the version in package.json.
  • Reflects these changes in CHANGELOG.md.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/documents.ts Added a subscription to handle file deletion and update diagnostics.
package.json Updated the version to 0.23.3.
CHANGELOG.md Updated changelog to document the diagnostics fix and version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Diagnostics remain if a file is deleted

2 participants