Skip to content

ci(admission): pick up an edited pull-request body in the deletion acknowledgement check #943

Open

Description

@devantler

Problem

When a pull request removes a managed resource from deploy/, the deletion guard asks the author to add a Deletion-Acknowledged: line to the pull-request body. The "Repository PR admission" check runs that guard on the body from its triggering event, and the workflow runs only on opened, synchronize and reopened. So after the author adds the line, the check stays red. Re-running it reuses the old event and fails again. The only ways out are pushing a new commit, which stales any review, or closing and reopening the pull request.

The 🧪 CI and 🛡️ Deploy guards workflows run the same guard and do pick up an edited body. CI runs on edited, and the deploy-guards workflow reads the body from the API.

Seen on #937.

What to do

Make the admission check pick up an edited body the way the deploy-guards workflow does. Read the current body from the API at run time, or add edited to its triggers, whichever keeps its trusted-source guarantees. A re-run after editing the body should then pass.

Done when

  • Adding the acknowledgment to the body and then re-running (or editing) makes "Repository PR admission" pass, with no new commit and no reopen.
  • A body without the acknowledgment still fails it.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions