You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ci(admission): pick up an edited pull-request body in the deletion acknowledgement check #943
When a pull request removes a managed resource from deploy/, the deletion guard asks the author to add a Deletion-Acknowledged: line to the pull-request body. The "Repository PR admission" check runs that guard on the body from its triggering event, and the workflow runs only on opened, synchronize and reopened. So after the author adds the line, the check stays red. Re-running it reuses the old event and fails again. The only ways out are pushing a new commit, which stales any review, or closing and reopening the pull request.
The 🧪 CI and 🛡️ Deploy guards workflows run the same guard and do pick up an edited body. CI runs on edited, and the deploy-guards workflow reads the body from the API.
Make the admission check pick up an edited body the way the deploy-guards workflow does. Read the current body from the API at run time, or add edited to its triggers, whichever keeps its trusted-source guarantees. A re-run after editing the body should then pass.
Done when
Adding the acknowledgment to the body and then re-running (or editing) makes "Repository PR admission" pass, with no new commit and no reopen.
Activity