Repository navigation
feat(actions): publish and sign releases as the calling product - #935
Conversation
Add actions/publish-app, a composite action products call from their own release workflow. Its keyless signatures name the calling workflow on its release tag, so the platform can trust each tenant's own repository instead of every revision of the shared publisher. Before any registry contact it refuses unless the ref is refs/tags/v<semver>, the workflow ref is the caller's own at that tag, the tagged commit is checked out and is an ancestor of the explicitly fetched default branch (unknown ancestry refuses), and the inputs, deploy-path and app-manifest are valid. It builds (deployment), verifies the main-CI image (prebuilt-webapp) or publishes manifests only, pins the digest, stages the whole deploy path, signs both digests, verifies them against the caller's identity and only then exposes the version and stable latest. The occupied-version guard runs before the first write, before staging and before exposure. Port the app-manifest input from #922 into the action and the shared prebuilt verifier. The reusable publish workflows are unchanged; the workflow dry-run job becomes test-publish-app-workflow so the action owns test-publish-app. Closes #925 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code coverage overviewLanguages: Go, C# Go / code-coverage/test
C# / code-coverage/dotnet
Go / code-coverage/go
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Review of #935. flux push and tag no longer take --creds: they read the registry login docker/login-action wrote. The action has its own version check that gives curl the login and the bearer token in private config files, so the token reaches no argv. The shared require-unpublished-version guard and the retiring reusable workflows are unchanged. Admission now also refuses a checkout below the workspace root or with a persisted git credential (the checkout is the image build context), resets any inherited Authorization header before the default-branch fetch, and refuses a deploy-path that holds links or special files or differs from the tagged commit (changed, removed or untracked files, ignored ones included). The test records the argv of every program a step runs and requires that none carries the token. New cases cover a fetched default branch that is not a commit, a failed ancestry walk, both persisted-credential forms, the header reset and each deploy-path refusal, with an ablation for every new guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-review of #935. The persisted-credential check matched only URL-scoped headers (http.<url>.extraheader), so a checkout with a plain http.extraheader, which git sends to every host, passed. Match both forms, add the case and an ablation that restores the old pattern. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai review |
Action not completed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
@coderabbitai review |
Action not completed
|
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: f90b749
- CodeRabbit: rate limited on this PR at 2026-11-14T21:39:18Z ("Review limit reached", next included review ~22:38Z) after an earlier refusal at 20:22:20Z; portfolio-wide LIMITED since 21:15:18Z (review-lane-health)
- Codex: usage limit since 2026-11-14T20:27:42Z per review-lane-health (first seen 12:19:01Z, ksail#8183); maintainer-only to lift
- Cursor Bugbot: team usage limit since 2026-11-14T20:29:32Z per review-lane-health (first seen 03:47:50Z, platform#6244); maintainer-only to lift
Verdict: no P0/P1 findings
🤖 Generated with Claude Code
Why
Today every product publishes through the shared publish workflows, so every signature carries the shared workflow's identity and the platform has to approve each publisher revision. ADR 0017 (epic devantler-tech/monorepo#5046) moves signing to the products themselves: each product signs its own releases, and the platform trusts each tenant's own repository on release tags (devantler-tech/platform#6265).
What
A new
publish-appaction that a product calls from its own release workflow. It publishes the same image and manifests artifact as the shared workflows, in three modes: build an image for a Deployment, reuse the product's verified main-CI image for a WebApp, or publish manifests only (the configuration tenants that use the manifests workflow today).Security properties
https://github.com/<owner>/<repo>/.github/workflows/<file>@refs/tags/vX.Y.Z, with the GitHub OIDC issuer.v<semver>tag, whose workflow is not the caller's own at that tag, whose checkout is not the tagged commit at the workspace root, whose checkout still holds a git credential (callers must check out withpersist-credentials: false), or whose tagged commit is not on the default branch. It fetches the default branch explicitly; if that cannot be established, it refuses. Bad inputs and app manifests are refused at the same point, and so is a deploy folder that holds links or special files or differs from the tagged commit, so the signed manifests are exactly the tagged source.latestmove. A failed verification exposes nothing.Ported from #922: the
app-manifestinput (the app manifest inside the deploy folder, for base/dev/prod overlays), with its strict path checks and test cases, now lives in the action and the shared prebuilt-image verifier. This supersedes #922, which can be closed once this lands.Tests run the action's real steps with registry stubs and real Git: every refusal above leaves the registry untouched, each mode publishes, and nothing is exposed when verification, the image copy or the version check fails. Mutation controls remove each guard from a copy of the action and require a test to fail.
Deliberately out of scope
publish-appandpublish-manifestsworkflows are unchanged until every consumer has moved. Known and deliberately left alone: they still pass the registry token on command lines (flux--creds, and curl--userin the shared version check they use), since they are being retired. The caller pin and publisher-revision checks that only existed for the shared identity are not carried over.Closes #925
👉 After merge/promotion: devantler-tech/platform#6265 must trust the products' own release-tag identities before a product switches to this action.
🤖 Generated with Claude Code