Skip to content

feat(actions): publish and sign releases as the calling product - #935

Merged
devantler merged 3 commits into
mainfrom
claude/publish-action-925
Nov 14, 2026
Merged

devantler merged 3 commits into
mainfrom
claude/publish-action-925

Conversation

@devantler

@devantler devantler commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

Today every product publishes through the shared publish workflows, so every signature carries the shared workflow's identity and the platform has to approve each publisher revision. ADR 0017 (epic devantler-tech/monorepo#5046) moves signing to the products themselves: each product signs its own releases, and the platform trusts each tenant's own repository on release tags (devantler-tech/platform#6265).

What

A new publish-app action that a product calls from its own release workflow. It publishes the same image and manifests artifact as the shared workflows, in three modes: build an image for a Deployment, reuse the product's verified main-CI image for a WebApp, or publish manifests only (the configuration tenants that use the manifests workflow today).

Security properties

  • The signer is the product itself. Signatures name the calling workflow on its release tag, https://github.com/<owner>/<repo>/.github/workflows/<file>@refs/tags/vX.Y.Z, with the GitHub OIDC issuer.
  • Only reviewed release tags publish. Before any registry contact (no login, read or write) it refuses a run that is not on a complete v<semver> tag, whose workflow is not the caller's own at that tag, whose checkout is not the tagged commit at the workspace root, whose checkout still holds a git credential (callers must check out with persist-credentials: false), or whose tagged commit is not on the default branch. It fetches the default branch explicitly; if that cannot be established, it refuses. Bad inputs and app manifests are refused at the same point, and so is a deploy folder that holds links or special files or differs from the tagged commit, so the signed manifests are exactly the tagged source.
  • Verify before expose. An already published version is refused before the first write and checked again before staging and before exposure. Image and manifests are signed by digest, both signatures are verified against the caller's identity, and only then do the version and (for stable releases) latest move. A failed verification exposes nothing.
  • No credential on any command line. The registry tools use the login the job already made, the default-branch fetch gets the token through its environment, and the version check reads its credentials from private files. The tests record every program the action runs and fail if any of them receives the token.

Ported from #922: the app-manifest input (the app manifest inside the deploy folder, for base/dev/prod overlays), with its strict path checks and test cases, now lives in the action and the shared prebuilt-image verifier. This supersedes #922, which can be closed once this lands.

Tests run the action's real steps with registry stubs and real Git: every refusal above leaves the registry untouched, each mode publishes, and nothing is exposed when verification, the image copy or the version check fails. Mutation controls remove each guard from a copy of the action and require a test to fail.

Deliberately out of scope

  • Recovery of a release whose version tags were lost after signing stays in the shared workflows for now; carrying it over is a follow-up.
  • The shared publish-app and publish-manifests workflows are unchanged until every consumer has moved. Known and deliberately left alone: they still pass the registry token on command lines (flux --creds, and curl --user in the shared version check they use), since they are being retired. The caller pin and publisher-revision checks that only existed for the shared identity are not carried over.
  • No product adopts the action here, and the platform's trust rules are not touched.

Closes #925

👉 After merge/promotion: devantler-tech/platform#6265 must trust the products' own release-tag identities before a product switches to this action.

🤖 Generated with Claude Code

Add actions/publish-app, a composite action products call from their own
release workflow. Its keyless signatures name the calling workflow on its
release tag, so the platform can trust each tenant's own repository instead
of every revision of the shared publisher.

Before any registry contact it refuses unless the ref is refs/tags/v<semver>,
the workflow ref is the caller's own at that tag, the tagged commit is checked
out and is an ancestor of the explicitly fetched default branch (unknown
ancestry refuses), and the inputs, deploy-path and app-manifest are valid.
It builds (deployment), verifies the main-CI image (prebuilt-webapp) or
publishes manifests only, pins the digest, stages the whole deploy path,
signs both digests, verifies them against the caller's identity and only
then exposes the version and stable latest. The occupied-version guard runs
before the first write, before staging and before exposure.

Port the app-manifest input from #922 into the action and the shared
prebuilt verifier. The reusable publish workflows are unchanged; the
workflow dry-run job becomes test-publish-app-workflow so the action owns
test-publish-app.

Closes #925

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-code-quality

github-code-quality Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 986a624 claude/publish-actio... f90b749 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 986a624 claude/publish-actio... f90b749 +/-
100% 100% 0%

Go / code-coverage/go

main 986a624 claude/publish-actio... f90b749 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 14, 2026 21:18 UTC

devantler and others added 2 commits November 14, 2026 21:10
Review of #935. flux push and tag no longer take --creds: they read the
registry login docker/login-action wrote. The action has its own version
check that gives curl the login and the bearer token in private config
files, so the token reaches no argv. The shared require-unpublished-version
guard and the retiring reusable workflows are unchanged.

Admission now also refuses a checkout below the workspace root or with a
persisted git credential (the checkout is the image build context), resets
any inherited Authorization header before the default-branch fetch, and
refuses a deploy-path that holds links or special files or differs from the
tagged commit (changed, removed or untracked files, ignored ones included).

The test records the argv of every program a step runs and requires that
none carries the token. New cases cover a fetched default branch that is not
a commit, a failed ancestry walk, both persisted-credential forms, the header
reset and each deploy-path refusal, with an ablation for every new guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-review of #935. The persisted-credential check matched only URL-scoped
headers (http.<url>.extraheader), so a checkout with a plain
http.extraheader, which git sends to every host, passed. Match both forms,
add the case and an ablation that restores the old pattern.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between b0ee127 and f90b749.

Files selected for processing: 15

  • .github/agent-guides/validation.md
  • .github/scripts/ci-selection/inventory.json
  • .github/scripts/prepare-prebuilt-webapp.sh
  • .github/tests/test-ci-catalogue-scope.sh
  • .github/tests/test-ci-selection.sh
  • .github/tests/test-prebuilt-webapp.sh
  • .github/tests/test-publish-app-action.sh
  • .github/tests/test-publish-contract-job.sh
  • .github/workflows/ci.yaml
  • README.md
  • actions/publish-app/README.md
  • actions/publish-app/action.yaml
  • actions/publish-app/admit.sh
  • actions/publish-app/publish.sh
  • actions/publish-app/require-unpublished.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: f90b749

  • CodeRabbit: rate limited on this PR at 2026-11-14T21:39:18Z ("Review limit reached", next included review ~22:38Z) after an earlier refusal at 20:22:20Z; portfolio-wide LIMITED since 21:15:18Z (review-lane-health)
  • Codex: usage limit since 2026-11-14T20:27:42Z per review-lane-health (first seen 12:19:01Z, ksail#8183); maintainer-only to lift
  • Cursor Bugbot: team usage limit since 2026-11-14T20:29:32Z per review-lane-health (first seen 03:47:50Z, platform#6244); maintainer-only to lift

Verdict: no P0/P1 findings

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 14, 2026 21:43
@devantler
devantler merged commit 986a680 into main Nov 14, 2026
245 checks passed
@devantler
devantler deleted the claude/publish-action-925 branch November 14, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(actions): publish and sign releases as the calling product

1 participant