Skip to content

fix(labels): keep Release Please's lifecycle labels on agent-plugins - #945

Merged
devantler merged 1 commit into
mainfrom
claude/labels-autorelease-agent-plugins
Nov 15, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/labels-autorelease-agent-plugins

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The agent-plugins 3.0.0 release was merged but never tagged. Our label management deletes the label Release Please uses to recognise a merged release, so it lost track of 3.0.0 and proposed a bogus 4.0.0 that re-lists the whole history.

What

Declares Release Please's two lifecycle labels for agent-plugins, so label management keeps them instead of deleting them.

Fixes #944

👉 After merge: relabel agent-plugins#710 as pending so 3.0.0 is tagged. The agent does this.

The authoritative IssueLabels set deleted autorelease: pending minutes after
Release Please applied it, so the merged 3.0.0 release PR was never tagged and
the next release PR re-proposed the whole history as 4.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The label configuration comments now describe the shared taxonomy patch and the repository-specific dependency, ecosystem, and Release Please lifecycle labels. It adds autorelease: pending and autorelease: tagged, each with color ededed.

Severity of issue fixed: Medium

Merge Risk: Minimal · up to db51a

This adds the two Release Please lifecycle labels to agent-plugins so label reconciliation stops deleting them. The change is small and reversible, and no concrete merge-blocking risk was found. After merge, the post-merge relabeling of #710 and the #714 follow-up still need to be done separately.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: adding Release Please's lifecycle labels to agent-plugins so label management keeps them. The raw summary confirms the YAML now declares autorelease: pending and autoreleas…
Description check Passed The description states the problem (the 3.0.0 release went untagged because label management deleted the Release Please label) and the fix (declaring the two lifecycle labels for agent-plugins). It al…
Linked Issues check Passed [#944] The coding requirement is to declare autorelease: pending and autorelease: tagged for agent-plugins so label reconciliation keeps them. At the reviewed head, `deploy/labels/agent-plugins.ya…
Out of Scope Changes check Passed The change set consists of the deploy/labels/agent-plugins.yaml file. The supplied summary states that the IssueLabels change adds the two autorelease labels, and that the file comments were upd…
Full details: Title check

Explanation

The title names the change: adding Release Please's lifecycle labels to agent-plugins so label management keeps them. The raw summary confirms the YAML now declares autorelease: pending and autorelease: tagged. The title is specific, follows conventional-commit style, and matches the main change.

Full details: Description check

Explanation

The description states the problem (the 3.0.0 release went untagged because label management deleted the Release Please label) and the fix (declaring the two lifecycle labels for agent-plugins). It also links issue #944 and notes the post-merge relabeling step. This matches the changeset, so the description is related and specific.

Full details: Linked Issues check

Explanation

[#944] The coding requirement is to declare autorelease: pending and autorelease: tagged for agent-plugins so label reconciliation keeps them. At the reviewed head, deploy/labels/agent-plugins.yaml declares both labels under spec.forProvider.label of the IssueLabels resource agent-plugins, each with color ededed. The file comments explain that these labels are Release Please lifecycle labels and must not be deleted. The other two completion items in #944 (relabeling agent-plugins#710 as pending, Release Please tagging v3.0.0, and rebuilding or closing #714) are post-merge repository operations, not coding work. This assessment does not require them. The PR description states that an agent performs the relabeling after merge. Repository diff for the file was unavailable, so the change set was assessed from the file blob at head and the supplied summary. The blob shows the required declarations present.

Full details: Out of Scope Changes check

Explanation

The change set consists of the deploy/labels/agent-plugins.yaml file. The supplied summary states that the IssueLabels change adds the two autorelease labels, and that the file comments were updated to describe them. Those comment changes document the new labels and do not alter other behavior. The dependencies label entry in the file is described by the file comments as a pre-existing repo-specific extra. The raw diff was unavailable, so the exact origin of that entry is not confirmed from diff hunks. The summary does not list it as a new addition, and it does not connect to #944 in a way that makes it out of scope. No unrelated files are part of the change.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cc69bb2 and db51a27.

Files selected for processing: 1

  • deploy/labels/agent-plugins.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 36

  • GitHub Check: Run reviewed product admission
  • GitHub Check: zizmor
  • GitHub Check: CodeRabbit
  • GitHub Check: [Test] Enable Auto-Merge - Actor Trust Enabled / dry-run
  • GitHub Check: [Test] Scan for TODO Comments - Dry Run (vendor exclusion) / dry-run
  • GitHub Check: [Test] Scan for TODO Comments - Dry Run (ignore configured) / dry-run
  • GitHub Check: [Test] Scan for TODO Comments - Production Compatibility Defaults / todos
  • GitHub Check: [Test] Scan for TODO Comments - Production Steps Without a Project / todos
  • GitHub Check: 🧹 Validate manifests
  • GitHub Check: [Test] Create Release - Dry Run / Offline release decisions
  • GitHub Check: [Test] Dependency Review - Summary Comment (on-failure-warned)
  • GitHub Check: [Test] Dependency Review - Summary Comment (on-failure-clean)
  • GitHub Check: [Test] Stale Issues - Offline Lifecycle
  • GitHub Check: [Test] Dependency Review - Summary Comment (comment-created)
  • GitHub Check: [Test] Dependency Review - Summary Comment (on-failure-vulnerable)
  • GitHub Check: [Test] Upsert Issue - Offline Behavior
  • GitHub Check: [Test] Dependency Review - Summary Comment (compare-forbidden)
  • GitHub Check: [Test] Dependency Review - Summary Comment (comment-updated)
  • GitHub Check: [Lint] Shell Pipeline Assertions
  • GitHub Check: lint-readme-parity
  • GitHub Check: lint-ci-coverage-parity
  • GitHub Check: [Test] Dependency Review - Summary Comment (comment-rejected)
  • GitHub Check: [Test] Run .NET Tests - Authenticated Packages (ubuntu-latest)
  • GitHub Check: [Test] Dependency Review - Summary Comment (comments-unreadable)
  • GitHub Check: [Test] CI Run Budget (macos-latest)
  • GitHub Check: test-enable-auto-merge-on-pr
  • GitHub Check: test-publish-contracts
  • GitHub Check: [Test] Run .NET Tests - Authenticated Packages (windows-latest)
  • GitHub Check: [Test] Run .NET Tests - Authenticated Packages (macos-latest)
  • GitHub Check: [Test] Create Issues From TODOs - Offline Wrapper
  • GitHub Check: [Test] Dependency Review - Summary Comment (comment-never)
  • GitHub Check: [Test] CI Run Budget (ubuntu-latest)
  • GitHub Check: [Test] TODO Scanner - Isolated Image
  • GitHub Check: Select affected catalogue tests
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (go)
Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered
Path-based instructions: 1

Source excerpt: **`IssueLabels` is authoritative** (Terraform `github_issue_labels`): it declares a repo's **complete** label set and **removes** any undeclared label.

CodeRabbit inference engine (AGENTS.md)

Files:

  • deploy/labels/agent-plugins.yaml
Additional comments: 2

deploy/labels/agent-plugins.yaml: 2

25-25: Data Integrity & Integration

The comment's premise does not hold. The live agent-plugins label set has no github_actions label, and every live label is already in the rendered declared set, so authoritative reconciliation will not remove an existing automation label.

25-25: Data Integrity & Integration

The agent-plugins Release Please configuration and workflow could not be inspected, so it cannot be determined whether they use the label names declared here. The declarations match the lifecycle labels named in issue #944 and in the reported 3.0.0 incident. Confirming the label names in agent-plugins would resolve this concern. No change to this file is supported by the available evidence.

@github-code-quality

github-code-quality Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: C#, Go

C# / code-coverage/dotnet

main cc69bb2 claude/labels-autore... db51a27 +/-
100% 100% 0%

Go / code-coverage/go

main cc69bb2 claude/labels-autore... db51a27 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 15, 2026 00:27 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at db51a27c83

  • Tested: bash tests/issue-label-taxonomy.sh PASS (26 rendered repositories, eight mutation controls); kubectl kustomize deploy/ renders, and the agent-plugins IssueLabels now carries autorelease: pending and autorelease: tagged beside dependencies and the 17 canonical labels. CI green at this head (the one red, the release egress probe, was a StepSecurity API timeout — curl exit 28, not a policy result — and passed on rerun).
  • Reviewed: CodeRabbit full review at this head: no actionable comments, 0 threads.
  • Tried as a user: the user here is Release Please. Its runs on agent-plugins show it adding autorelease: pending and provider-upjet-github[bot] removing it within minutes, four times on 2026-11-14; the tag step then logs Expected 1 releases, only found 0. With the label declared, the authoritative set keeps it. Live proof after merge: relabel agent-plugins#710 and confirm the label survives a reconcile and v3.0.0 is tagged.

@devantler
devantler marked this pull request as ready for review November 15, 2026 00:30
@devantler
devantler merged commit 3cab796 into main Nov 15, 2026
405 of 407 checks passed
@devantler
devantler deleted the claude/labels-autorelease-agent-plugins branch November 15, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release Please lifecycle labels are deleted on agent-plugins, so 3.0.0 was never tagged

1 participant