Skip to content

fix(release): guard configuration publisher identities - #953

Merged
devantler merged 1 commit into
mainfrom
codex/github-config-signing-guard-926
Nov 16, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/github-config-signing-guard-926

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Configuration releases need a signing identity that only this repository's release pipeline can issue.

What

Require release-tag publication and reject callable execution before changing the publisher. Preserve existing publication while preparing the guarded transition.

Part of #926

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T17:37:50.259773Z f4d8223 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: f4d82237a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-code-quality

github-code-quality Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main dff1f12 codex/github-config-... f4d8223 +/-
50% 50% 0%

C# / code-coverage/dotnet

main dff1f12 codex/github-config-... f4d8223 +/-
100% 100% 0%

Go / code-coverage/go

main dff1f12 codex/github-config-... f4d8223 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 16, 2026 19:32 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at f4d82237a04d368364a64b9fa11d2504696c151b:

  • Exercised the real configuration-caller guard and the full manifests-promotion suite. The existing approved signer is accepted; callable/manual/branch triggers, extra authority, source replacement and malformed publication modes are refused. The local suite passed, including the late-version and unsigned-promotion negative controls.
  • Read the executed publication-contract job at this exact head. It passes the same caller boundary and native disposable-registry publication controls. Hosted required checks and all four required workflows pass; the separately configured Code Quality rule has no readable head verdict and remains UNVERIFIED.
  • Codex reviewed this head without findings; current paginated review surfaces contain no unresolved finding or thread. Static review of the trigger, permission, source and publication boundaries found no additional issue.

This prerequisite tightens caller validation. The actual caller still uses the approved legacy publisher; #926 remains open for the own-signer transition, release and deployed trust readback.

@devantler
devantler marked this pull request as ready for review November 16, 2026 20:19
@devantler
devantler merged commit cc156a3 into main Nov 16, 2026
241 checks passed
@devantler
devantler deleted the codex/github-config-signing-guard-926 branch November 16, 2026 20:20
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Correction to the merge sequence: promotion queued a fresh deploy-guard job. The final read saw that job pending and returned a stop condition, but my tool batch incorrectly continued to the head-pinned merge. GitHub accepted the merge; the final preflight was incomplete.

The new deploy-guard job has now completed successfully at the same reviewed head f4d82237a04d368364a64b9fa11d2504696c151b. No source head changed, the current-head Codex review remains clean, and the paginated review read found no unresolved finding. The protected merge is cc156a3693019fdbe9817c46f1a91cd50a124695. Main CI and publication are separate follow-through checks.

I corrected the orchestration so a failed preflight ends the tool batch before any dependent mutation. The timing error remains part of this delivery record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant