Repository navigation
fix(agentic-engineering): pass the Claude plugin directory's checks - #659
Conversation
The plugin directory refused the submission on two blocking findings and
warned on two more:
- flux-operator-mcp and kubescape started from an inline `sh -c` program
the validator cannot follow. They now start from bundled launchers,
scripts/flux-operator-mcp.sh and scripts/kubescape-mcp.sh, run by bash at
${CLAUDE_PLUGIN_ROOT}, with the same KUBECONFIG fallback and hermetic tests.
- The github-mcp-headers self-test shipped stub values shaped like GitHub
tokens, which the secret scan reported. They are neutral stubs now.
- Add PRIVACY.md, linked from the README, and a 512 px
.claude-plugin/icon.png from the Devantler Tech orb.
- Add the README's Claude Code install line.
Bump agentic-engineering to 7.1.2.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard refuses every file type it does not scan, so the new .claude-plugin/icon.png made it report UNKNOWN and failed the packaged resources job. The icon is listing metadata for Anthropic's plugin directory; no agent runtime loads it as a definition. Pass it over only at exactly plugins/<plugin>/.claude-plugin/icon.png, only as a regular file, and only when it starts with the PNG signature. Any other image, a deeper path, a symlink or text renamed to icon.png stays UNKNOWN. Five self-test cases pin each boundary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@coderabbitai full review 🤖 Generated with Claude Code |
Action not completed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
CodeRabbit is rate-limited on this repository, so asking the next review lane. @codex review 🤖 Generated with Claude Code |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
CodeRabbit is rate-limited and Codex has reached its usage limit, so asking Cursor Bugbot next. The bare trigger follows in its own comment. 🤖 Generated with Claude Code |
|
@cursor review |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: ad6edbe6-f5ee-4b00-8129-f8ea14dc5627) |
#658 landed a broader, reviewed fix to the gh JSON-field guard: it skips signature-checked raster images anywhere under plugins/. That supersedes this branch's narrower listing-icon exception, so both guard files take main's version; this PR no longer changes the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the cluster launchers
Codex substitutes no ${CLAUDE_PLUGIN_ROOT} in a server's arguments, so it
would have run bash on a literal '${CLAUDE_PLUGIN_ROOT}/scripts/...' path and
lost both cluster servers. Codex now loads .codex-plugin/mcp.json, which
mirrors .mcp.json with those two launch paths plugin-relative under cwd ".";
validate-manifests.sh enforces the mirror and refuses a Codex manifest that
would load a ${CLAUDE_PLUGIN_ROOT} launch path.
The launchers are POSIX sh again, run by sh like the inline programs they
replace, so a BASH_ENV file cannot print onto the MCP stream. The Kubescape
launcher sets KS_SKIP_UPDATE_CHECK=true unless the user set it, so scans send
no version check carrying a cluster ID and node count. Both launcher tests
now pin each MCP file's wiring and start the Codex spelling from the plugin
root.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#660 added the coroot server and released 7.2.0. This branch's change becomes 7.2.1. The Codex MCP mirror is regenerated so it carries coroot, PRIVACY.md now covers coroot's pinned key and its data-directory files, and the README and resources doc keep main's coroot rows and sections, with both cluster servers needing a POSIX sh again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the maintainer's Claude Code session
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: cc1e354a1462af5cf51b44ab7fb19be7d459f588
- CodeRabbit: rate limited — "Review rate limited", next included review in 57 minutes (comment, 2026-11-07T11:06:19Z); recovers about 12:03Z.
- Codex: usage limit reached for code reviews (comment, 2026-11-07T11:06:52Z); no recovery time given.
- Cursor Bugbot: "Bugbot couldn't run - usage limit reached" (check-run 128386814740, 2026-11-07T11:08:43Z); no recovery time given.
How this was reviewed. An independent reviewer agent read the code without the author's conclusions, against this repository's review guidelines, in two rounds:
- At 67a62cf: it found two P1s.
- Codex substitutes no
${CLAUDE_PLUGIN_ROOT}inargs(verified in Codexrust-v0.166.0), so it would have lost both cluster servers. - PRIVACY.md left out Kubescape's version check to its update service, which carries a cluster ID and the node count.
- It also raised three nits:
BASH_ENVoutput on the MCP stream, the guard's icon check, and untested wiring.
- Codex substitutes no
- Fixes: 009394b fixes all five (the guard change was dropped for #658's).
- At this commit: the reviewer confirmed each fix by reading and running, found nothing at P0/P1, and raised the three nits threaded below.
Tried as a user.
- The real
flux-operator-mcp0.62.1 starts throughsh scripts/flux-operator-mcp.shin both spellings, withKUBECONFIGunset:- Claude Code's
${CLAUDE_PLUGIN_ROOT}path; - Codex's plugin-relative path, run from the plugin directory.
- Claude Code's
- In each it answers
initializeand lists 12 tools, none of them a write tool, with only JSON on stdout. claude plugin validate --profile directory --strict(2.1.317) passes with no warnings.validate-manifests.shpasses, and its self-test passes 474/474.- All 48 bundled helper self-tests pass, with no helper missing a test.
- shellcheck is clean, and CI is green.
Verdict: no P0/P1 findings
Why
Submitting
agentic-engineeringto the Claude plugin directory failed on two blocking findings and warned on two more. This PR fixes all four without breaking any other tool that loads the plugin.What changes
scripts/github-mcp-headers.test.shused stub values shaped like GitHub tokens[A-Za-z0-9_]+token, so the test covers the same contractflux-operator-mcpandkubescapestarted from inlinesh -cprogramsshlaunchers,scripts/flux-operator-mcp.shandscripts/kubescape-mcp.sh, which keep the sameKUBECONFIG→$HOME/.kube/configfallback.claude-plugin/icon.png, the Devantler Tech orb at 512 × 512PRIVACY.md, linked from the README by aPrivacylink, which the directory accepts. It lists what each bundled server sends, and to whomCross-tool launch
.mcp.jsonnames the launchers by${CLAUDE_PLUGIN_ROOT}, which Claude Code and VS Code substitute. Codex substitutes nothing inargs(verified in Codexrust-v0.166.0,plugin_config.rs), so it now loads.codex-plugin/mcp.json. That file is the same server map, with the two launchers named relative to the plugin and run fromcwd: ".".validate-manifests.shgainsvalidate_codex_mcp_mirror, which keeps that file an exact mirror of.mcp.json. It also refuses a Codex manifest that would load a${CLAUDE_PLUGIN_ROOT}launch path. Copilot CLI's handling of the variable in a plugin's.mcp.jsonis not verified, and the README says so.Privacy
The Kubescape launcher sets
KS_SKIP_UPDATE_CHECK=trueunless you set it yourself. Otherwise Kubescape's scans would send a version check carrying a cluster ID and the node count. PRIVACY.md also covers #660'scorootserver and its data-directory files.The plugin moves to 7.2.1. The README gains the Claude Code install line.
Not changed here
allowed-toolsingit-commitanddependency-scanning. The issues are filed as git-commit skill: step 3 can leave changes out of a merge commit, andgit add --resolvedhas no fallback before Git 2.56 github/awesome-copilot#6255 and dependency-scanning skill:allowed-toolspre-approves unrestricted Bash, including the downloads it says to ask about github/copilot-advanced-security-plugin#7.headersHelperwaits for the portal's re-validation of this version.Validation
validate-manifests.shpasses, and its self-test passes 474/474, including 15 new mirror cases.KUBECONFIGresolution,KS_SKIP_UPDATE_CHECK, aBASH_ENVthat prints (the stub runs asbash -p, and a control running the launcher withbashfails this case), and usage errors.flux-operator-mcp0.62.1 starts through the launcher, in both the Claude spelling and the Codex spelling, withKUBECONFIGunset.initializeand lists 12 tools, none of them a write tool, with only JSON on stdout.claude plugin validate --profile directory --strict(Claude Code 2.1.317) passes with no warnings. The portal's own re-validation is still to run.🤖 Generated with Claude Code