Skip to content

fix(agentic-engineering): pass the Claude plugin directory's checks - #659

Merged
devantler merged 5 commits into
mainfrom
claude/plugin-directory-validation
Nov 7, 2026
Merged

devantler merged 5 commits into
mainfrom
claude/plugin-directory-validation

Conversation

@devantler

@devantler devantler commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Why

Submitting agentic-engineering to the Claude plugin directory failed on two blocking findings and warned on two more. This PR fixes all four without breaking any other tool that loads the plugin.

What changes

Finding Cause Fix
⛔ Secret in a shipped file scripts/github-mcp-headers.test.sh used stub values shaped like GitHub tokens Neutral stub values. The helper accepts any [A-Za-z0-9_]+ token, so the test covers the same contract
⛔ Command path can't be followed flux-operator-mcp and kubescape started from inline sh -c programs They start from bundled POSIX sh launchers, scripts/flux-operator-mcp.sh and scripts/kubescape-mcp.sh, which keep the same KUBECONFIG → $HOME/.kube/config fallback
⚠ No icon — .claude-plugin/icon.png, the Devantler Tech orb at 512 × 512
⚠ No privacy policy URL devantler.tech has no privacy page New PRIVACY.md, linked from the README by a Privacy link, which the directory accepts. It lists what each bundled server sends, and to whom

Cross-tool launch

.mcp.json names the launchers by ${CLAUDE_PLUGIN_ROOT}, which Claude Code and VS Code substitute. Codex substitutes nothing in args (verified in Codex rust-v0.166.0, plugin_config.rs), so it now loads .codex-plugin/mcp.json. That file is the same server map, with the two launchers named relative to the plugin and run from cwd: ".".

validate-manifests.sh gains validate_codex_mcp_mirror, which keeps that file an exact mirror of .mcp.json. It also refuses a Codex manifest that would load a ${CLAUDE_PLUGIN_ROOT} launch path. Copilot CLI's handling of the variable in a plugin's .mcp.json is not verified, and the README says so.

Privacy

The Kubescape launcher sets KS_SKIP_UPDATE_CHECK=true unless you set it yourself. Otherwise Kubescape's scans would send a version check carrying a cluster ID and the node count. PRIVACY.md also covers #660's coroot server and its data-directory files.

The plugin moves to 7.2.1. The README gains the Claude Code install line.

Not changed here

Validation

  • Gates:
    • validate-manifests.sh passes, and its self-test passes 474/474, including 15 new mirror cases.
    • The version-bump, changelog, skill-edit, license and gh-JSON guards pass.
    • shellcheck is clean.
    • All 48 bundled helper self-tests pass.
  • Launcher tests:
    • They cover KUBECONFIG resolution, KS_SKIP_UPDATE_CHECK, a BASH_ENV that prints (the stub runs as bash -p, and a control running the launcher with bash fails this case), and usage errors.
    • They pin both MCP files' wiring, and start the Codex spelling from the plugin root.
  • Tried as a user:
    • The real flux-operator-mcp 0.62.1 starts through the launcher, in both the Claude spelling and the Codex spelling, with KUBECONFIG unset.
    • It answers initialize and lists 12 tools, none of them a write tool, with only JSON on stdout.
  • Directory check: claude plugin validate --profile directory --strict (Claude Code 2.1.317) passes with no warnings. The portal's own re-validation is still to run.
  • Review: CodeRabbit was rate limited, and Codex and Bugbot had reached their usage limits, so a local review round stands in for them. An independent reviewer found two P1s at 67a62cf, now fixed, and nothing at P0 or P1 at cc1e354.

🤖 Generated with Claude Code

The plugin directory refused the submission on two blocking findings and
warned on two more:

- flux-operator-mcp and kubescape started from an inline `sh -c` program
  the validator cannot follow. They now start from bundled launchers,
  scripts/flux-operator-mcp.sh and scripts/kubescape-mcp.sh, run by bash at
  ${CLAUDE_PLUGIN_ROOT}, with the same KUBECONFIG fallback and hermetic tests.
- The github-mcp-headers self-test shipped stub values shaped like GitHub
  tokens, which the secret scan reported. They are neutral stubs now.
- Add PRIVACY.md, linked from the README, and a 512 px
  .claude-plugin/icon.png from the Devantler Tech orb.
- Add the README's Claude Code install line.

Bump agentic-engineering to 7.1.2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The guard refuses every file type it does not scan, so the new
.claude-plugin/icon.png made it report UNKNOWN and failed the packaged
resources job. The icon is listing metadata for Anthropic's plugin
directory; no agent runtime loads it as a definition.

Pass it over only at exactly plugins/<plugin>/.claude-plugin/icon.png, only
as a regular file, and only when it starts with the PNG signature. Any other
image, a deeper path, a symlink or text renamed to icon.png stays UNKNOWN.
Five self-test cases pin each boundary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 57 minutes.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4a64f2da-fd2d-400a-86d7-2e7d7c329041
Commits

Reviewing files that changed from the base of the PR and between 52b1d97 and 67a62cf.

Files ignored due to path filters: 1

  • plugins/agentic-engineering/.claude-plugin/icon.png is excluded by !**/*.png
Files selected for processing: 17

  • .claude-plugin/marketplace.json
  • .github/plugin/marketplace.json
  • docs/resources.md
  • plugins/agentic-engineering/.claude-plugin/plugin.json
  • plugins/agentic-engineering/.codex-plugin/plugin.json
  • plugins/agentic-engineering/.mcp.json
  • plugins/agentic-engineering/CHANGELOG.md
  • plugins/agentic-engineering/PRIVACY.md
  • plugins/agentic-engineering/README.md
  • plugins/agentic-engineering/plugin.json
  • plugins/agentic-engineering/scripts/flux-operator-mcp.sh
  • plugins/agentic-engineering/scripts/flux-operator-mcp.test.sh
  • plugins/agentic-engineering/scripts/github-mcp-headers.test.sh
  • plugins/agentic-engineering/scripts/kubescape-mcp.sh
  • plugins/agentic-engineering/scripts/kubescape-mcp.test.sh
  • scripts/guard-gh-json-fields.sh
  • scripts/guard-gh-json-fields.test.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devantler

Copy link
Copy Markdown
Contributor Author

CodeRabbit is rate-limited on this repository, so asking the next review lane.

@codex review

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-07T11:06:44.928390Z
We couldn’t complete this review. Comment @codex review to try again.
67a62cf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@devantler

Copy link
Copy Markdown
Contributor Author

CodeRabbit is rate-limited and Codex has reached its usage limit, so asking Cursor Bugbot next. The bare trigger follows in its own comment.

🤖 Generated with Claude Code

@devantler

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor

cursor Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: ad6edbe6-f5ee-4b00-8129-f8ea14dc5627)

devantler and others added 3 commits November 7, 2026 12:15
#658 landed a broader, reviewed fix to the gh JSON-field guard: it skips
signature-checked raster images anywhere under plugins/. That supersedes
this branch's narrower listing-icon exception, so both guard files take
main's version; this PR no longer changes the guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the cluster launchers

Codex substitutes no ${CLAUDE_PLUGIN_ROOT} in a server's arguments, so it
would have run bash on a literal '${CLAUDE_PLUGIN_ROOT}/scripts/...' path and
lost both cluster servers. Codex now loads .codex-plugin/mcp.json, which
mirrors .mcp.json with those two launch paths plugin-relative under cwd ".";
validate-manifests.sh enforces the mirror and refuses a Codex manifest that
would load a ${CLAUDE_PLUGIN_ROOT} launch path.

The launchers are POSIX sh again, run by sh like the inline programs they
replace, so a BASH_ENV file cannot print onto the MCP stream. The Kubescape
launcher sets KS_SKIP_UPDATE_CHECK=true unless the user set it, so scans send
no version check carrying a cluster ID and node count. Both launcher tests
now pin each MCP file's wiring and start the Codex spelling from the plugin
root.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#660 added the coroot server and released 7.2.0. This branch's change becomes
7.2.1. The Codex MCP mirror is regenerated so it carries coroot, PRIVACY.md
now covers coroot's pinned key and its data-directory files, and the README
and resources doc keep main's coroot rows and sections, with both cluster
servers needing a POSIX sh again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the maintainer's Claude Code session

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: cc1e354a1462af5cf51b44ab7fb19be7d459f588

  • CodeRabbit: rate limited — "Review rate limited", next included review in 57 minutes (comment, 2026-11-07T11:06:19Z); recovers about 12:03Z.
  • Codex: usage limit reached for code reviews (comment, 2026-11-07T11:06:52Z); no recovery time given.
  • Cursor Bugbot: "Bugbot couldn't run - usage limit reached" (check-run 128386814740, 2026-11-07T11:08:43Z); no recovery time given.

How this was reviewed. An independent reviewer agent read the code without the author's conclusions, against this repository's review guidelines, in two rounds:

  • At 67a62cf: it found two P1s.
    • Codex substitutes no ${CLAUDE_PLUGIN_ROOT} in args (verified in Codex rust-v0.166.0), so it would have lost both cluster servers.
    • PRIVACY.md left out Kubescape's version check to its update service, which carries a cluster ID and the node count.
    • It also raised three nits: BASH_ENV output on the MCP stream, the guard's icon check, and untested wiring.
  • Fixes: 009394b fixes all five (the guard change was dropped for #658's).
  • At this commit: the reviewer confirmed each fix by reading and running, found nothing at P0/P1, and raised the three nits threaded below.

Tried as a user.

  • The real flux-operator-mcp 0.62.1 starts through sh scripts/flux-operator-mcp.sh in both spellings, with KUBECONFIG unset:
    • Claude Code's ${CLAUDE_PLUGIN_ROOT} path;
    • Codex's plugin-relative path, run from the plugin directory.
  • In each it answers initialize and lists 12 tools, none of them a write tool, with only JSON on stdout.
  • claude plugin validate --profile directory --strict (2.1.317) passes with no warnings.
  • validate-manifests.sh passes, and its self-test passes 474/474.
  • All 48 bundled helper self-tests pass, with no helper missing a test.
  • shellcheck is clean, and CI is green.

Verdict: no P0/P1 findings

Comment thread scripts/validate-manifests.sh Resolved
Comment thread plugins/agentic-engineering/PRIVACY.md Resolved
@devantler
devantler marked this pull request as ready for review November 7, 2026 12:00
@devantler
devantler merged commit 9200323 into main Nov 7, 2026
24 checks passed
@devantler
devantler deleted the claude/plugin-directory-validation branch November 7, 2026 12:00
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 7, 2026
This was referenced Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant