Skip to content

docs(coverage): record the Svelte adoption and the Astro removal - #672

Merged
devantler merged 1 commit into
mainfrom
claude/docs-svelte-coverage-652
Nov 10, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/docs-svelte-coverage-652

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

The skill coverage overview still listed SvelteKit as an open gap and Astro as covered. Both changed when the plugin started bundling the Svelte team's guidance and dropped the Astro skill, so the overview pointed agents and readers at the wrong state.

What

The overview now shows SvelteKit as covered and Astro as not bundled, with where to get the Astro skill when it is needed. It also records the decision on the two Svelte candidates: one adopted, one rejected because it downloads and runs unpinned code that the bundled documentation server already replaces.

Fixes #652

🤖 Generated with Claude Code

The coverage matrix still listed SvelteKit as an open gap and Astro as
covered. Since 7.0.0 the plugin bundles the Svelte team's best-practices
skill and documentation server, and no longer bundles the Astro skill.
The candidate table now states the decision on both Svelte skills: the
best-practices skill is adopted, and the code writer is rejected because
it runs an unpinned package on every call while the bundled server offers
the same tools.

Part of #652

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The coverage documentation now lists SvelteKit as covered since 7.0.0 and Astro as not bundled, with an installation command for Astro’s upstream skill. It records the adoption of svelte-core-bestpractices and the rejection of svelte-code-writer. The prioritized gaps list marks SvelteKit complete and moves Prometheus and OpenTelemetry to position 6. A changelog reference was added.

Possibly related PRs

Merge Risk: Minimal · up to 48b17

The coverage update has no established merge-blocking issue; it is ready for normal checks.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Directly linked issue #652 has coding and eval requirements beyond the documentation update.

Met by this PR:
- Coverage update: the SvelteKit row in docs/skill-coverage.md (head) now reads Covered si…
Provide evidence for the following, then reassess:
1. Confirm at the reviewed head (or in the 7.0.0 release) that svelte-core-bestpractices has upstream provenance and appears in both plugin manifests and the catalogue, with its MIT licence…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title clearly summarizes the coverage update by naming the Svelte adoption and Astro removal from the bundled skills.
Description check Passed The description explains the SvelteKit coverage update, the Astro skill status, and the Svelte candidate decisions. It is related to the changeset.
Out of Scope Changes check Passed The reviewed change set is limited to docs/skill-coverage.md (summary: +7/-5 lines). The file is the coverage record that #652 requires updating. The changes fall into three groups:
- SvelteKit row an…
Full details: Out of Scope Changes check

Explanation

The reviewed change set is limited to docs/skill-coverage.md (summary: +7/-5 lines). The file is the coverage record that #652 requires updating. The changes fall into three groups:

  • SvelteKit row and Done entry: directly required by #652.
  • Astro row (Not bundled, with the 7.0.0 changelog install reference): the PR description states this purpose. It corrects the same overview because the astro skill left the bundle in 7.0.0. The #652 near-miss case also refers to astro.
  • Prioritized gaps renumbering (Prometheus and OpenTelemetry moved to position 6): a consequence of removing SvelteKit from the open gaps list.
    No unrelated code, manifest or skill changes are shown in the evidence. The head file was read in full up to the truncation point. The diff itself could not be read, so the summary is the basis for this verdict.
Full details: Linked Issues check

Explanation

Directly linked issue #652 has coding and eval requirements beyond the documentation update.

Met by this PR:

  • Coverage update: the SvelteKit row in docs/skill-coverage.md (head) now reads Covered since 7.0.0, with the bundled Svelte resources listed. The Done line in Prioritized gaps records SvelteKit (#652).
  • Decision record: the Candidate comparison table at head records svelte-core-bestpractices as adopted and svelte-code-writer as rejected, with reasons (unpinned npx execution; overlap with the bundled svelte server).

Not established:

  • Adoption artefacts (upstream provenance, both manifests, catalogue and licence/notice row, version bump, CI). The PR diff does not show changes to these files. The doc attributes adoption to 7.0.0. The diff and the base revision could not be read (changed blobs missing from checkout; base file read failed), so the 7.0.0 state was not verified.
  • Activation cases (should-trigger, near-miss, adherence, over-trigger) in the #651 eval suite, or listed there if the suite has not landed. Neither this PR nor the head doc lists them, and the state of #651 was not verified.
  • Description-character report for the listing budget. No skill is added in this PR, so this may not apply.

Resolution

Provide evidence for the following, then reassess:

  1. Confirm at the reviewed head (or in the 7.0.0 release) that svelte-core-bestpractices has upstream provenance and appears in both plugin manifests and the catalogue, with its MIT licence row and notice in plugins/agentic-engineering/resources/THIRD-PARTY-NOTICES.md.
  2. Confirm the 7.0.0 version bump and CI state for that adoption.
  3. Confirm whether #651's eval suite exists. If it does, confirm it contains the four Svelte activation cases from #652. If it does not, confirm the cases are listed on #651 or in the PR.
  4. State whether a description-character count applies, given that this PR adds no skill.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5fe09ca6-8b0c-4c17-9617-a752fe8fc519
Commits

Reviewing files that changed from the base of the PR and between f57eb03 and 48b17ff.

Files selected for processing: 1

  • docs/skill-coverage.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 1

  • GitHub Check: CodeRabbit
Additional comments: 1

docs/skill-coverage.md: 1

121-121: Functional Correctness

The cases are listed in #651, as the acceptance criterion permits.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Tried as a reader of the overview, at 48b17ff8. This is documentation with nothing to run, so the check is each changed statement against the repository at this head:

Review: CodeRabbit reviewed this head and generated no actionable comments. CI is green.

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 10, 2026 13:37
@devantler
devantler merged commit 85bfff2 into main Nov 10, 2026
24 checks passed
@devantler
devantler deleted the claude/docs-svelte-coverage-652 branch November 10, 2026 13:37
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Adopt the Svelte team's skills for the SvelteKit products

1 participant