Repository navigation
refactor(plugins): keep one plugin manifest set - #709
Merged
Merged
Conversation
Replace the custom preparation, proposal and publication workflows and their scripts with release-please (#705, part 1 of 2). One root package bumps .metadata.version in both marketplace manifests through a reviewable release PR opened with the App token; merging it tags vX.Y.Z and publishes the GitHub release with the workflow token. Per-plugin version and changelog gates are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete the duplicate .github/plugin/marketplace.json and the top-level plugins/<name>/plugin.json. VS Code, the Copilot CLI, Claude Code and Codex all read .claude-plugin/marketplace.json and each plugin's .claude-plugin/plugin.json; Codex keeps its own .codex-plugin manifest. validate-manifests.sh drops the two parity checks and instead refuses a manifest copy at any other path VS Code reads. The version, changelog, publish and scorecard tools, the skill-sync workflow and release-please now use the one set. Each plugin gets a patch bump and changelog entry. Part of #705. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t-set-705 # Conflicts: # .github/workflows/release-please.yaml # README.md # docs/marketplace-releases.md # docs/scripts.md # docs/tool-ownership.md # release-please-config.json # scripts/ci-script-test-sharding-workflow.test.sh
devantler
commented
Nov 14, 2026
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 1327b81
- CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
- Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
- Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)
Verdict: no P0/P1 findings
🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#705 part 2. Each plugin shipped two manifest sets:
.github/plugin/marketplace.jsonplus a top-levelplugins/<name>/plugin.json, and.claude-plugin/marketplace.jsonplusplugins/<name>/.claude-plugin/plugin.json. A large share ofvalidate-manifests.shexisted only to keep the two in parity.Stacked on #708 (part 1, release-please). Merge #708 first, then retarget this PR to
main.Evidence every tool reads
.claude-plugin/pluginMarketplaceService.tschecksmarketplace.json,.plugin/,.github/plugin/, then.claude-plugin/marketplace.json. For a plugin it checks.plugin/plugin.json,.claude-plugin/plugin.json, thenplugin.json. The marketplace search queries the Claude, Copilot and OpenPlugin types alike..claude-plugin/marketplace.jsonand.claude-plugin/plugin.json. The maintainer accepted docs plus source for Copilot.plugin validatepasses, and all three plugins install (7.8.4, 1.0.3, 1.1.1). Cache SKILL.md counts are 94, 1 and 3, and no top-levelplugin.jsonis present.CODEX_HOME: Codex reads.claude-plugin/marketplace.json. All three install, with SKILL.md counts of 94/94, 1/1 and 3/3.What
.github/plugin/marketplace.jsonandplugins/*/plugin.json. Keep.claude-plugin/and the Codex-specific.codex-plugin/plugin.json.validate-manifests.sh: drop only the checks that tested parity between the two sets. Every other check now applies to the one set:validate_single_manifest_setcheck: it refuses a manifest copy at any other path VS Code reads, symlinks included, because VS Code would read most of those before the canonical file. It has six new tests, andvalidate-manifests.test.shpasses 470/470.bump-plugin-version.sh,check-plugin-version-bump.sh,plugin-changelog.sh,publish-skill-metadata.sh(now refuses the deleted paths),plugin-scorecard.sh,guard-bundled-skill-edits.sh, theupdate-agent-skills.yamlgit addline, andrelease-please-config.json. Docs are updated too.Validation
validate-manifests.sh,check-plugin-version-bump.sh,plugin-changelog.sh check,refresh-desired-state-digests.sh --check,check-instruction-size.shandshellcheckall pass.actionlintreports only the existingconcurrency.queuefinding.recheck-open-prs-observations, which already fails locally on main; refactor(ci): replace recheck-open-prs with the merge queue #707 deletes it.Follow-up outside this repo
monorepo
.claude/scripts/programmed-bot-review-exemption.shstill allow-lists.github/plugin/marketplace.jsonand top-levelplugin.json. Nothing breaks, and CI now refuses those paths, but the allow-list should be tightened.Closes #705
🤖 Generated with Claude Code