Skip to content

refactor(plugins): keep one plugin manifest set - #709

Merged
devantler merged 3 commits into
mainfrom
claude/single-manifest-set-705
Nov 14, 2026
Merged

devantler merged 3 commits into
mainfrom
claude/single-manifest-set-705

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

#705 part 2. Each plugin shipped two manifest sets: .github/plugin/marketplace.json plus a top-level plugins/<name>/plugin.json, and .claude-plugin/marketplace.json plus plugins/<name>/.claude-plugin/plugin.json. A large share of validate-manifests.sh existed only to keep the two in parity.

Stacked on #708 (part 1, release-please). Merge #708 first, then retarget this PR to main.

Evidence every tool reads .claude-plugin/

  • VS Code: pluginMarketplaceService.ts checks marketplace.json, .plugin/, .github/plugin/, then .claude-plugin/marketplace.json. For a plugin it checks .plugin/plugin.json, .claude-plugin/plugin.json, then plugin.json. The marketplace search queries the Claude, Copilot and OpenPlugin types alike.
  • Copilot CLI: GitHub's CLI plugin reference lists .claude-plugin/marketplace.json and .claude-plugin/plugin.json. The maintainer accepted docs plus source for Copilot.
  • Claude Code 2.1.325, installed from this branch with an isolated config: plugin validate passes, and all three plugins install (7.8.4, 1.0.3, 1.1.1). Cache SKILL.md counts are 94, 1 and 3, and no top-level plugin.json is present.
  • Codex 0.167.0, installed from this branch with an isolated CODEX_HOME: Codex reads .claude-plugin/marketplace.json. All three install, with SKILL.md counts of 94/94, 1/1 and 3/3.

What

  • Delete .github/plugin/marketplace.json and plugins/*/plugin.json. Keep .claude-plugin/ and the Codex-specific .codex-plugin/plugin.json.
  • validate-manifests.sh: drop only the checks that tested parity between the two sets. Every other check now applies to the one set:
    • manifest shape, rename history, entry-to-manifest agreement and orphan refusal;
    • catalogue Resources, desired-state and provenance;
    • the Codex comparison and its normalization-failure coverage.
  • New validate_single_manifest_set check: it refuses a manifest copy at any other path VS Code reads, symlinks included, because VS Code would read most of those before the canonical file. It has six new tests, and validate-manifests.test.sh passes 470/470.
  • Writers and readers updated: bump-plugin-version.sh, check-plugin-version-bump.sh, plugin-changelog.sh, publish-skill-metadata.sh (now refuses the deleted paths), plugin-scorecard.sh, guard-bundled-skill-edits.sh, the update-agent-skills.yaml git add line, and release-please-config.json. Docs are updated too.
  • Patch bumps with changelog entries, because package contents changed: agentic-engineering 7.8.4, ksail 1.0.3, vibe-coding 1.1.1.

Validation

  • validate-manifests.sh, check-plugin-version-bump.sh, plugin-changelog.sh check, refresh-desired-state-digests.sh --check, check-instruction-size.sh and shellcheck all pass.
  • actionlint reports only the existing concurrency.queue finding.
  • All script tests pass except recheck-open-prs-observations, which already fails locally on main; refactor(ci): replace recheck-open-prs with the merge queue #707 deletes it.

Follow-up outside this repo

monorepo .claude/scripts/programmed-bot-review-exemption.sh still allow-lists .github/plugin/marketplace.json and top-level plugin.json. Nothing breaks, and CI now refuses those paths, but the allow-list should be tightened.

Closes #705

🤖 Generated with Claude Code

devantler and others added 2 commits November 14, 2026 20:38
Replace the custom preparation, proposal and publication workflows and
their scripts with release-please (#705, part 1 of 2). One root package
bumps .metadata.version in both marketplace manifests through a reviewable
release PR opened with the App token; merging it tags vX.Y.Z and publishes
the GitHub release with the workflow token. Per-plugin version and
changelog gates are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Delete the duplicate .github/plugin/marketplace.json and the top-level
plugins/<name>/plugin.json. VS Code, the Copilot CLI, Claude Code and
Codex all read .claude-plugin/marketplace.json and each plugin's
.claude-plugin/plugin.json; Codex keeps its own .codex-plugin manifest.

validate-manifests.sh drops the two parity checks and instead refuses a
manifest copy at any other path VS Code reads. The version, changelog,
publish and scorecard tools, the skill-sync workflow and release-please
now use the one set. Each plugin gets a patch bump and changelog entry.

Part of #705.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Base automatically changed from claude/release-please-705 to main November 14, 2026 21:34
…t-set-705

# Conflicts:
#	.github/workflows/release-please.yaml
#	README.md
#	docs/marketplace-releases.md
#	docs/scripts.md
#	docs/tool-ownership.md
#	release-please-config.json
#	scripts/ci-script-test-sharding-workflow.test.sh

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: 1327b81

  • CodeRabbit: review limit reached on agent-plugins since 2026-11-14T19:14:34Z ("Review limit reached"); no review delivered for this PR
  • Codex: account usage limit since 2026-11-14T12:19:01Z (devantler-tech/ksail#8183), review-lane-health DOWN
  • Cursor Bugbot: team usage limit since 2026-11-14T03:47:50Z (devantler-tech/platform#6244)

Verdict: no P0/P1 findings

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 14, 2026 22:01
@devantler
devantler added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 1995242 Nov 14, 2026
23 checks passed
@devantler
devantler deleted the claude/single-manifest-set-705 branch November 14, 2026 22:17
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Keep one plugin manifest set and release with release-please

1 participant