Skip to content

ci: adopt the template's shared lint, CodeQL, CodeRabbit and Renovate config - #385

Merged
devantler merged 2 commits into
mainfrom
claude/adopt-shared-template-config
Nov 15, 2026
Merged

devantler merged 2 commits into
mainfrom
claude/adopt-shared-template-config

Conversation

@devantler

@devantler devantler commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

What

Onboards this tenant onto the application template's shared configuration (monorepo ADR 0018, 2026-11-15 amendment; epic devantler-tech/monorepo#5062), the same change wedding-app took in devantler-tech/wedding-app#480. It takes the template's current shared files, so the next template-sync is nearly empty:

  • Lint: .github/workflows/lint.yaml (MegaLinter cupcake, read-only) and .github/mega-linter.base.yml, .markdownlint.json, .yamllint.yml. A new megalinter job in ci.yaml calls it and counts towards CI - Required Checks. The existing lint job (ESLint) stays; MegaLinter leaves JavaScript and TypeScript to it.
  • Code scanning: .github/workflows/codeql.yaml (advanced setup, languages detected from the files). It stays off until the maintainer turns CodeQL default setup off and sets CODEQL_SETUP=advanced.
  • Review: .coderabbit.yaml, layered over the organization's settings.
  • Dependencies: renovate.json for the image tags in deploy/ only; Dependabot keeps everything else. It does nothing until the repository is enrolled in Renovate.
  • Synced workflows: release.yaml, template-sync.yaml, stale-issues.yaml and cd.yaml move to the template's content: the repository-ID guard and the devantler-tech/.github v21.6.2 callers. The publish-app pin is unchanged.
  • Overlays this tenant owns: .mega-linter.yml (extends the base) and .github/codeql/codeql-config.yml, both now in .templatesyncignore, with the template-only stacks/, scripts/scaffold.sh (+ test) and validate-stacks.yaml.

Nothing is diverged from: every shared file is taken as the template has it.

Fixes the shared linters ask for

  • .stylelintrc.json extends stylelint-config-standard and allows Tailwind v4's string @import and its at-rules (@theme, @source, @utility and the rest). It is the same file wedding-app carries; both Tailwind sites could share it from the template later.
  • src/app.css takes stylelint's notation fixes (#fff, rgb(36 53 40 / 18%), lower-case georgia), each rendering the same, and labels the theme's font and shadow groups with comments.
  • The Dockerfile HEALTHCHECK uses JSON notation (hadolint DL3025) and asks 127.0.0.1 instead of localhost: inside the image localhost resolves to ::1 first while nginx listens on IPv4 only, so the old check was refused and the container never reported healthy.
  • The runtime stage names its user, USER 101 (trivy DS-0002 fails an image with no USER line). nginx-unprivileged already runs as UID 101 and deploy/ runs the pod as UID 1000, so nothing changes at runtime.

Validation

  • actionlint and zizmor clean on .github/workflows/; scripts/workflow-caller-pin-contract.test.sh and scripts/npm-toolchain.test.sh pass; hadolint and trivy config clean; stylelint passes on src/app.css.
  • The image builds and, read-only with all capabilities dropped, serves GET / 200 as UID 101, reports healthy (the old localhost check is refused inside the same container), and exits 0 on SIGTERM.
  • The new MegaLinter job runs in this PR's CI.

Maintainer-only switches

  • CodeQL: turn default setup off (Settings → Code security), then set the repository variable CODEQL_SETUP to advanced.
  • Renovate: enroll the repository.

🤖 Generated with Claude Code

… config

Take the application template's current shared files so the next
template-sync is nearly empty, add the MegaLinter job to the required
checks, and list this tenant's overlays and the template-only scaffold in
.templatesyncignore. stylelint learns Tailwind v4 in .stylelintrc.json and
app.css takes its style fixes; the HEALTHCHECK uses JSON notation and asks
127.0.0.1, since localhost resolves to ::1 while nginx listens on IPv4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action not completed

Head commit changed.

trivy's DS-0002 fails a Dockerfile with no USER line. nginx-unprivileged
already runs as UID 101, so stating it changes nothing at runtime.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

Warning

Some tools did not complete. Review the errors below.

Biome (2.6.3)

src/app.css

File contains syntax errors that prevent linting: Line 11: Tailwind-specific syntax is disabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@devantler have exceeded the limit for the number of chat messages per hour. Please wait 17 minutes and 47 seconds before sending another message.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T02:55:35.654549Z d4e98d1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: d4e98d1cd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review November 15, 2026 02:55
@devantler
devantler requested a review from a team as a code owner November 15, 2026 02:55
@devantler
devantler merged commit 5d456b3 into main Nov 15, 2026
31 checks passed
@devantler
devantler deleted the claude/adopt-shared-template-config branch November 15, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant