Repository navigation
ci: adopt the template's shared lint, CodeQL, CodeRabbit and Renovate config - #385
Conversation
… config Take the application template's current shared files so the next template-sync is nearly empty, add the MegaLinter job to the required checks, and list this tenant's overlays and the template-only scaffold in .templatesyncignore. stylelint learns Tailwind v4 in .stylelintrc.json and app.css takes its style fixes; the HEALTHCHECK uses JSON notation and asks 127.0.0.1, since localhost resolves to ::1 while nginx listens on IPv4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai full review |
Action not completed
|
trivy's DS-0002 fails a Dockerfile with no USER line. nginx-unprivileged already runs as UID 101, so stating it changes nothing at runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Some tools did not complete. Review the errors below.
|
@coderabbitai full review |
Rate Limit Exceeded
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What
Onboards this tenant onto the application template's shared configuration (monorepo ADR 0018, 2026-11-15 amendment; epic devantler-tech/monorepo#5062), the same change wedding-app took in devantler-tech/wedding-app#480. It takes the template's current shared files, so the next template-sync is nearly empty:
.github/workflows/lint.yaml(MegaLinter cupcake, read-only) and.github/mega-linter.base.yml,.markdownlint.json,.yamllint.yml. A newmegalinterjob inci.yamlcalls it and counts towardsCI - Required Checks. The existinglintjob (ESLint) stays; MegaLinter leaves JavaScript and TypeScript to it..github/workflows/codeql.yaml(advanced setup, languages detected from the files). It stays off until the maintainer turns CodeQL default setup off and setsCODEQL_SETUP=advanced..coderabbit.yaml, layered over the organization's settings.renovate.jsonfor the image tags indeploy/only; Dependabot keeps everything else. It does nothing until the repository is enrolled in Renovate.release.yaml,template-sync.yaml,stale-issues.yamlandcd.yamlmove to the template's content: the repository-ID guard and thedevantler-tech/.githubv21.6.2 callers. Thepublish-apppin is unchanged..mega-linter.yml(extends the base) and.github/codeql/codeql-config.yml, both now in.templatesyncignore, with the template-onlystacks/,scripts/scaffold.sh(+ test) andvalidate-stacks.yaml.Nothing is diverged from: every shared file is taken as the template has it.
Fixes the shared linters ask for
.stylelintrc.jsonextendsstylelint-config-standardand allows Tailwind v4's string@importand its at-rules (@theme,@source,@utilityand the rest). It is the same file wedding-app carries; both Tailwind sites could share it from the template later.src/app.csstakes stylelint's notation fixes (#fff,rgb(36 53 40 / 18%), lower-casegeorgia), each rendering the same, and labels the theme's font and shadow groups with comments.DockerfileHEALTHCHECKuses JSON notation (hadolint DL3025) and asks127.0.0.1instead oflocalhost: inside the imagelocalhostresolves to::1first while nginx listens on IPv4 only, so the old check was refused and the container never reported healthy.USER 101(trivy DS-0002 fails an image with noUSERline). nginx-unprivileged already runs as UID 101 anddeploy/runs the pod as UID 1000, so nothing changes at runtime.Validation
actionlintandzizmorclean on.github/workflows/;scripts/workflow-caller-pin-contract.test.shandscripts/npm-toolchain.test.shpass;hadolintandtrivy configclean;stylelintpasses onsrc/app.css.GET /200 as UID 101, reportshealthy(the oldlocalhostcheck is refused inside the same container), and exits 0 on SIGTERM.Maintainer-only switches
CODEQL_SETUPtoadvanced.🤖 Generated with Claude Code