Skip to content

chore: sync changes from the upstream template - #388

Merged
devantler merged 1 commit into
mainfrom
chore/template-sync_81cf629
Nov 16, 2026
Merged

devantler merged 1 commit into
mainfrom
chore/template-sync_81cf629

Conversation

@botantler-1

@botantler-1 botantler-1 Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The existing publication guard would reject the shared serialization lock needed by the pending signing migration.

What

Adopt the reviewed template compatibility change before changing the publisher. Accept the two known locks while preserving signing, identity and permission checks.

Part of #383

Signed-off-by: devantler <github-action@actions-template-sync.noreply.github.com>
@botantler-1
botantler-1 Bot force-pushed the chore/template-sync_81cf629 branch from 8dc3eb3 to 22e9493 Compare November 16, 2026 15:46
@devantler
devantler marked this pull request as draft November 16, 2026 15:50
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T16:03:58.179472Z 22e9493 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 22e94933ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Readiness at the current reviewed head: the two-file diff is identical to the template prerequisite #302. Static review and native CI cover this programmed branch; the branch execution classifier grants no local execution exemption. Native Publish Pin Approved exercised the real guard and reported 47 passed, 0 failed, including the alternate publication lock and rejection of an unrelated group. The publisher workflow is unchanged.

All native CI is green, exact-head Codex review is clean, every finding surface is clear, and the branch contains current main. Code Quality remains a configured native gate whose head analysis is unreadable; the normal protected merge will enforce it. This lands compatibility before the separate signing migration.

@devantler
devantler marked this pull request as ready for review November 16, 2026 16:21
@devantler
devantler merged commit 4137814 into main Nov 16, 2026
29 checks passed
@devantler
devantler deleted the chore/template-sync_81cf629 branch November 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant