Skip to content

fix(email): use SES's enum value for the MAIL FROM failure behaviour - #90

Merged
devantler merged 1 commit into
mainfrom
claude/ses-mail-from-enum-5481
Nov 13, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/ses-mail-from-enum-5481

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

The company mail domain's custom bounce domain was never set. AWS rejected the setting, because the configuration spelled one value in a form the AWS API does not accept, so outbound mail would keep using Amazon's own bounce address.

What

This uses the exact value the AWS API expects, so SES sets the custom bounce domain. Nothing else changes.

Part of devantler-tech/platform#5481

🤖 Generated with Claude Code

SES rejected the MAIL FROM attributes with a validation error: the API
accepts only USE_DEFAULT_VALUE or REJECT_MESSAGE for behaviorOnMxFailure,
and the provider passes the value through unchanged, so UseDefaultValue
left the custom MAIL FROM domain unset. Use the API's own value.

Part of devantler-tech/platform#5481.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler
devantler marked this pull request as ready for review November 13, 2026 20:32
@devantler

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The MAIL FROM fallback comment and the behaviorOnMxFailure setting now use USE_DEFAULT_VALUE instead of UseDefaultValue.

Merge Risk: Minimal · up to 74f62

This fixes the MAIL FROM failure behaviour so that AWS accepts the setting and outbound mail uses the custom bounce domain. No actionable merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the actual change: the MAIL FROM failure behaviour value is switched to the SES enum value the AWS API accepts. The raw summary describes the same switch from UseDefaultValue to USE_DE…
Description check Passed The description explains the problem and the fix. It says the custom bounce domain was never set because AWS rejected the value spelled in a form the API does not accept. It also says the change uses …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the actual change: the MAIL FROM failure behaviour value is switched to the SES enum value the AWS API accepts. The raw summary describes the same switch from UseDefaultValue to USE_DEFAULT_VALUE in the MAIL FROM attributes YAML, so the title matches the changeset. It is short, specific, and readable, and it avoids vague terms.

Full details: Description check

Explanation

The description explains the problem and the fix. It says the custom bounce domain was never set because AWS rejected the value spelled in a form the API does not accept. It also says the change uses the exact value the API expects and that nothing else changes. This matches the one-file change to the MAIL FROM attributes YAML.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 35a5229c-f38b-49e3-acff-f9bf4c37ec5f
Commits

Reviewing files that changed from the base of the PR and between afeaf99 and 74f6230.

Files selected for processing: 1

  • deploy/email/email-identity-mail-from-attributes.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Additional context used

Code guidelines: 1

AGENTS.md — auto-discovered
Path-based instructions: 2

Source excerpt: **Layout:** all managed resources live under `deploy/`, referenced from `deploy/kustomization.yaml`.

CodeRabbit inference engine (AGENTS.md)

Files:

  • deploy/email/email-identity-mail-from-attributes.yaml
Source excerpt: Conventions for AI agents working in this repo.

CodeRabbit inference engine (AGENTS.md)

Files:

  • deploy/email/email-identity-mail-from-attributes.yaml

@devantler
devantler merged commit acce00f into main Nov 13, 2026
15 checks passed
@devantler
devantler deleted the claude/ses-mail-from-enum-5481 branch November 13, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant