Repository navigation
feat(deploy): project the platform's runtime Secret into the WebApp - #594
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
The WebApp now projects the platform-composed `business-site-runtime` Secret with exactly four items (company-disclosure as disclosure, portal-settings, portal-client-secret, portal-database-ca) and passes `--portal-settings-projection /run/webapp-inputs/portal-settings`. While sign-in is off the settings item holds only a comment line, so the portal reads none of the other portal items and stays closed. The package validator admits exactly that Secret, those items and the appended argument pair, and the package tests refuse missing, renamed, extra or relocated inputs. The Docker smoke mounts fictional files for all four items, proves serving fails closed without the disclosure or the settings item, and keeps the portal closed with a comment-only settings file. The public receipt check omits the settings argument, which it refuses by design. The projection fixture now verifies every copied item and drops macOS tar metadata that a Linux daemon cannot set. The retained disclosure ExternalSecret is no longer projected; removing it is a later cleanup. Merge only after `business-site-runtime` exists in production: without it the Pods cannot start. Refs #302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#598's billing test pinned the WebApp's one projection to business-site-disclosure and forbade a portal-settings argument. This PR projects the platform's business-site-runtime instead, with the portal settings file. The test keeps its point: one Secret, never optional, and no Numina or Stripe Secret in it. Refs #302 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0deec24 to
bb6c29d
Compare
@coderabbitai review |
Action performed
|
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Ready at
|

Summary
The tenant package now projects the one Secret the platform composes,
business-site-runtime, instead of the disclosure-only Secret. Portal sign-in stays off.deploy/webapp.yaml: the single projection becomesbusiness-site-runtimewith four items:company-disclosureasdisclosure, plusportal-settings,portal-client-secretandportal-database-caat their own names. The arguments gain--portal-settings-projection /run/webapp-inputs/portal-settings; all existing arguments stay. While sign-in is off,portal-settingscontains only a#comment line, so the portal reads none of the other items.scripts/check-tenant-package.mjs): admits exactly that Secret, those four items in that order and the appended argument pair. The package tests add refusals for:scripts/tenant-runtime-smoke.test.mjs):--check-serving-public) runs without the settings argument, because it refuses portal settings by design.deploy/external-secret-disclosure.yamlstays declared but is no longer projected; removing it is a later cleanup.deploy/README.mdand the deploy rule inAGENTS.mdare updated to match.Validation
kubectl kustomize deploy | node scripts/check-tenant-package.mjsaccepts the package.node --test scripts/tenant-package.test.mjspasses 105/105.node --test scripts/container-contract.test.mjspasses 15/15.bash scripts/runtime-verification.test.shpasses.node --test scripts/runtime-stages.test.mjspasses 43/43.ee69fc5(2026-10-22), before both the--public-hostand--portal-settings-projectionarguments existed, so it exits withruntime arguments are invalid; main's own no-argument smoke has the same limitation. CI runs the smoke against its newly built production image.node scripts/tenant-runtime-smoke.test.mjsagainst that image passes 3/3.Refs #302
Update (2026-11-15)
business-site-runtimeexists in thebusiness-sitenamespace and is synced. The portal database and the customer Dex are healthy, so this projection has its Secret.main:AGENTS.mdanddeploy/README.mdwere resolved by keepingmain's text and this PR's runtime-Secret sentence.business-site-disclosure. It now asserts this PR's single projection,business-site-runtime, and that no Numina or Stripe Secret is in it (bb6c29d).node --test scripts/tenant-package.test.mjspasses 130/130.🤖 Generated with Claude Code