Skip to content

feat(deploy): mount the portal's SMTP credential - #617

Merged
devantler merged 1 commit into
mainfrom
claude/portal-smtp-mount
Nov 15, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/portal-smtp-mount

Conversation

@devantler

Copy link
Copy Markdown
Contributor

The portal emails order confirmations and withdrawal receipts itself (#615) through the site's send-only SES sender. The platform now adds that sender's credential to business-site-runtime as smtp-username and smtp-password (devantler-tech/platform#6368, merged). This PR projects the two items so the portal settings can name them.

What changes

  • deploy/webapp.yaml projects smtp-username and smtp-password from business-site-runtime at their own names.
  • The package checker, its test and the runtime smoke fixture expect the six items.
  • deploy/README.md says six items and adds Portal email inputs: the two PORTAL_SMTP_*_FILE settings lines and the optional defaults.

Nothing reads the files until the portal settings name them. The portal queues email only for orders and withdrawals behind their false-default flags, and sends only while sign-in is on.

Why it is safe to ship now

A missing projected key keeps new pods from starting, so this had to wait for platform#6368. It has deployed. Read-only checks on the live cluster, status only, no values:

  • ExternalSecret business-site-runtime is at generation 2 with smtp_username and smtp_password in its data, and Ready=True SecretSynced.
  • CiliumNetworkPolicy business-site-portal-egress allows email-smtp.eu-central-1.amazonaws.com.

Validation

  • node --test scripts/tenant-package.test.mjs: 130 pass.
  • scripts/tenant-runtime-smoke.test.mjs needs the image CI builds; CI runs it with the new fixture items.

Part of #21

🤖 Generated with Claude Code

The platform now adds the site's send-only SES credential to
business-site-runtime as smtp-username and smtp-password
(devantler-tech/platform#6368, deployed and synced). Project both
items so the portal settings can name them; nothing reads them until
then. Document the two settings lines.

Part of #21

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for The WebApp now projects smtp-username and smtp-password from business-site-runtime; check the package checker, tests and README agree, and that nothing reads the files before the portal settings name them.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T22:10:03.343065Z 9e87bc8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9e87bc8e6a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 1.69s
✅ CSS stylelint 1 0 0 0 2.14s
✅ GO golangci-lint yes yes no no 142.35s
✅ GO revive 179 0 0 0.97s
✅ HTML djlint 5 0 0 2.55s
✅ HTML htmlhint 5 0 0 0.48s
✅ JSON jsonlint 2 0 0 0.08s
✅ JSON prettier 2 0 0 0 0.7s
✅ JSON v8r 2 0 0 1.49s
✅ MARKDOWN markdownlint 17 0 0 0 1.59s
✅ MARKDOWN markdown-table-formatter 17 0 0 0 0.36s
✅ REPOSITORY betterleaks yes no no 0.81s
✅ REPOSITORY checkov yes no no 17.97s
✅ REPOSITORY git_diff yes no no 0.21s
✅ REPOSITORY grype yes no no 203.27s
✅ REPOSITORY osv-scanner yes no no 173.19s
✅ REPOSITORY secretlint yes no no 1.02s
✅ REPOSITORY syft yes no no 3.33s
✅ REPOSITORY trivy yes no no 17.39s
✅ REPOSITORY trivy-sbom yes no no 0.17s
✅ REPOSITORY trufflehog yes no no 2.24s
✅ SPELL cspell 206 0 0 6.41s
✅ SPELL lychee 24 0 0 143.24s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters COPYPASTE_JSCPD,CSS_STYLELINT,GO_GOLANGCI_LINT,GO_REVIVE,HTML_DJLINT,HTML_HTMLHINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_CSPELL,SPELL_LYCHEE

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@devantler
devantler marked this pull request as ready for review November 15, 2026 22:24
@devantler
devantler requested a review from a team as a code owner November 15, 2026 22:24
@devantler
devantler merged commit 4b8b267 into main Nov 15, 2026
40 checks passed
@devantler
devantler deleted the claude/portal-smtp-mount branch November 15, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant