Repository navigation
feat(portal): enforce fair use and show each client's priority level - #624
Conversation
@codex review for fair use: per-client advisory lock and in-progress check in persistRequest, derived priority level from billing orders, operator closure |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 876bdc8aed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7bc39ef to
8453916
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
876bdc8 to
d293d92
Compare
@codex review for Re-review after the findings on the previous head were fixed (see the replies on each thread). |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
8453916 to
17a1650
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d293d92 to
358e044
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
358e044 to
af94829
Compare
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5edcbec to
61fe284
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
af94829 to
636e6b3
Compare
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
61fe284 to
3a06b48
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
636e6b3 to
bee8e02
Compare
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3a06b48 to
3164548
Compare
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bee8e02 to
157ead2
Compare
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
The standard add-ons include two feature-request priority tiers, Priority and Express, with fair use: one request in progress per customer at a time. - A client's level is the highest tier among the monthly add-ons of their orders that still bill, else Standard; the operator's request page shows it. - A client with hosting cannot send a new request while another of theirs is in progress. The check runs in the request's transaction under a per-client advisory lock; a retry is not a second request. - The operator marks a request finished on its page (portal_request_closures, migration v26), and the client can then send the next one. - The retention purge deletes a former client's closures too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex review on #624: a retry of a submission that already exists is not a new request, so it keeps its receipt even while another request is in progress, as REQUESTS.md documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jscpd found the Express order and the new-request form repeated across the fair-use tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
djlint H015 on #624: the feature-request line sat on the heading's line. It now opens the next line, so the page renders the same text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
157ead2 to
0db2aa7
Compare
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |

Stacked on #623 (add-ons). Review only this PR's commit.
The standard add-ons include two monthly feature-request priority tiers. With Standard (included), hosted projects' requests are picked up in a monthly round. Priority (400 a month) picks them up about weekly. Express (1,000 a month) starts work and replies within 1 business day. Fair use applies to every level: one request in progress per customer at a time. The terms text is #621, a draft for danish-law's review.
What changes
POST /operator/requests/{id}/finished,portal_request_closures, migration v26). The client can then send the next one. The page shows when it was finished.Tests
TestFairUseOneRequestInProgress: an Express order, a refused second request, the operator's view of the level and the request in progress, an idempotent "finished", then the next request admitted and a third refused.TestFeatureLevels: Priority while the order bills, Standard after a withdrawal, and no limit without hosting.Mutation checks on the refusal and the "still bills" condition are load-bearing. The frozen maintenance inventory still matches: the new alert renders nothing when absent. The full Go suite passes, and golangci-lint, vet, gofmt, jscpd and cspell are clean.
Part of #21
🤖 Generated with Claude Code