Skip to content

feat(site): list the standard add-ons under the offers - #626

Merged
devantler merged 3 commits into
mainfrom
claude/public-addons
Nov 16, 2026
Merged

devantler merged 3 commits into
mainfrom
claude/public-addons

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Stacked on #623 (add-ons). Review only this PR's commit.

The maintainer approved the standard add-ons, and the public site lists them under the offers. Per the danish-law review, the list stays hidden until the add-ons can actually be ordered. It is behind a new default-off FEATURE_ADDONS, which the portal's activation flips together with FEATURE_PORTAL_PRIVACY.

What changes

  • src/components/business/addons.ts: the standard add-ons (standardAddons) with their prices, offerings and EN/DA text, plus the list's short copy. Monthly add-ons need hosting, the launch discount never applies to add-ons, Priority and Express follow the fair-use rule in the terms, and anything else gets a fixed-price quote.
  • The home page (/, /da/) renders the list after the price note, only with FEATURE_ADDONS. Monthly prices read "a month" / "om måneden", and the extra language "each" / "pr. stk.". It falls to one column on narrow screens.
  • scripts/proposal-offerings.test.mjs fails when the portal's catalogue (offerings.json addons) and the public list differ, with a control that a changed price is noticed.
  • scripts/package-runtime.sh pins FEATURE_ADDONS=false in the production package. scripts/vat-activation.test.mjs refuses it unpinned or released, and AGENTS.md names it beside FEATURE_PORTAL_PRIVACY.

Validation

  • node --test scripts/proposal-offerings.test.mjs: 6 pass. node --test scripts/vat-activation.test.mjs: 50 pass.
  • npm run build passes. With the flag off, neither home page contains the list. With FEATURE_ADDONS=true, both list all 11 add-ons with the catalogue's prices, e.g. "Extra language: DKK 1,500 each" / "Ekstra sprog: 1.500 kr. pr. stk.".

Part of #21

🤖 Generated with Claude Code

@devantler
devantler force-pushed the claude/public-addons branch from 250fdbe to 900efa1 Compare November 16, 2026 00:49
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Review this PR's own commits; it is stacked on its base branch (rebased onto #625).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T02:30:29.302434Z 792b5ce Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 900efa11a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Review this PR's own commits; it is stacked on its base branch, now on #625's latest head.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 3b91620326

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for Re-review this PR's own commits after rebasing onto main (#625 merged); findings on earlier heads are answered on their threads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 5e9dc14fe6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler force-pushed the claude/portal-addons branch from 3a06b48 to 3164548 Compare November 16, 2026 01:47
Base automatically changed from claude/portal-addons to main November 16, 2026 02:26
devantler and others added 3 commits November 16, 2026 03:27
The home page lists the standard add-ons (src/components/business/
addons.ts) with their fixed VAT-inclusive prices, EN and DA, under the
offers: monthly ones per month, the extra language per unit, and a note
that monthly add-ons need hosting and the launch discount never applies
to them.

scripts/proposal-offerings.test.mjs fails when the portal's catalogue
(offerings.json addons) and the public list differ. The list stays
behind the default-off FEATURE_ADDONS until the add-ons can be ordered;
the production packager pins it false, and the activation test refuses
it unpinned or released.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps the public add-on list equal to the portal's catalogue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler
devantler force-pushed the claude/public-addons branch from 5e9dc14 to 792b5ce Compare November 16, 2026 02:28
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 792b5cedbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 0.96s
✅ CSS stylelint 1 0 0 0 1.83s
✅ GO golangci-lint yes yes no no 118.16s
✅ GO revive 187 0 0 0.8s
✅ HTML djlint 5 0 0 1.62s
✅ HTML htmlhint 5 0 0 0.32s
✅ JSON jsonlint 2 0 0 0.09s
✅ JSON prettier 2 0 0 0 0.76s
✅ JSON v8r 2 0 0 0.92s
✅ MARKDOWN markdownlint 17 0 0 0 1.43s
✅ MARKDOWN markdown-table-formatter 17 0 0 0 0.28s
✅ REPOSITORY betterleaks yes no no 0.66s
✅ REPOSITORY checkov yes no no 15.03s
✅ REPOSITORY git_diff yes no no 0.15s
✅ REPOSITORY grype yes no no 181.89s
✅ REPOSITORY osv-scanner yes no no 143.53s
✅ REPOSITORY secretlint yes no no 0.89s
✅ REPOSITORY syft yes no no 2.53s
✅ REPOSITORY trivy yes no no 9.9s
✅ REPOSITORY trivy-sbom yes no no 0.24s
✅ REPOSITORY trufflehog yes no no 3.69s
✅ SPELL cspell 214 0 0 5.07s
✅ SPELL lychee 24 0 0 130.18s

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.2.0 --custom-flavor-setup --custom-flavor-linters COPYPASTE_JSCPD,CSS_STYLELINT,GO_GOLANGCI_LINT,GO_REVIVE,HTML_DJLINT,HTML_HTMLHINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_CSPELL,SPELL_LYCHEE

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@devantler
devantler marked this pull request as ready for review November 16, 2026 02:40
@devantler
devantler requested a review from a team as a code owner November 16, 2026 02:40
@devantler
devantler merged commit f427b12 into main Nov 16, 2026
40 checks passed
@devantler
devantler deleted the claude/public-addons branch November 16, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant