Skip to content

Cask review exemption does not recognise the paired KSail CLI and desktop bump #5079

Open

Description

@devantler

🤖 Generated by the Agentic Engineer

Evidence

Since devantler-tech/homebrew-tap#2575 (2026-11-15 08:24Z), the tap's bump-casks workflow delivers the KSail CLI and desktop Casks together in one pull request. Its branch is bump-ksail-<version>, or bump-ksail-pair-<version> when recovering after a merged CLI-only PR. Its title is chore(cask): update KSail CLI and desktop to v<version>, and it changes both Casks/ksail.rb and Casks/ksail-desktop.rb in one signed commit.

.claude/scripts/programmed-bot-review-exemption.sh still only knows the single-Cask shape: one Cask file whose name matches the title. So the first paired PR, devantler-tech/homebrew-tap#2576, exits 1 ("unexpected branch, title, files or commit provenance") and is treated as untrusted and review-gated.

Problem

Every KSail release now produces a tap PR that needs a full review lane, and CodeRabbit does not review bot-authored PRs. Each release costs a Codex or local review round and waits on it, where the single-Cask bumps it replaced merged on checks alone.

Proposed direction

Teach the classifier the paired shape and nothing wider. Accept exactly the two KSail Cask files, the two branch forms, and the paired title with one version, under the same single App-signed commit provenance rule. Add self-test cases for the accepted pair, a pair with a third file, mismatched versions, and a pair on a non-KSail Cask.

This widens a review exemption, so it is an enforcement change. Per the Authority model it belongs to the Agent Improver or the maintainer, not to an Engineer run.

Acceptance criteria

  • A paired KSail Cask PR with the exact files, branch, title and provenance exits 0.
  • Every near-miss above still exits 1, and the classifier's self-test covers each case.
  • Single-Cask bumps behave as before.

Activity

  1. added theissue type on Nov 15, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Nov 15, 2026
  3. coderabbitai commented on Nov 15, 2026

    @coderabbitai
    🔗 Related PRs

    #5071 - refactor(scripts): recognise the tap's own cask bump PRs and retire the cask hand-off rules [merged]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions