Skip to content

fix(publishing): validate application-owned release signers - #296

Merged
devantler merged 1 commit into
mainfrom
codex/own-release-289-2d5d
Nov 15, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/own-release-289-2d5d

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The template currently rejects the application-owned release signer that its publisher switch needs, keeping deployment updates waiting.

What

Validate that signer against the platform’s exact release rule while preserving the existing publication safeguards. The actual publisher switch and released application verification remain separate work.

Part of #289

Validate the strict direct publisher frame and its exact own-release matcher before the starter caller switch. Preserve the shared publisher paths and existing controls. Part of #289.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at 6be1e0be8f16652148a45e4e40f3701c3c975953:

  • The new direct-publisher case first failed because the existing envelope check rejected it. The complete check now passes with 92 safety mutations, 36 subject controls and 53 producer controls against the current Platform source.
  • Bypassing the portable execution-frame guard makes the environment-override rejection fail; restoring the guard returns the full check to green. The existing portable approval suite also passes all 45 cases.
  • Every documented template contract passes, including all eight scaffold combinations, rename/build checks, portable caller pins, workflow callers, tenant CI, Pod Security, RBAC, network and VPA structural checks. ShellCheck and whitespace validation pass. The commit signature verifies.

User-path scope: I exercised the actual validator with the direct-publisher fixture and decoded Platform matcher, including rejected shared-only, explicit shared-revision, environment-override and branch-publication cases. This proves offline compatibility; it does not prove a real release, admission or reconciliation. The existing publisher remains selected, and #289 remains open. Hosted CI and an exact-head external review are still required before promotion.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The test harness now checks tenant-owned release subjects and tag-only direct-caller workflows. Producer controls cover acceptance of the own-release rule and rejection of shared-only authorization, explicit shared revisions, environment overrides, and branch publication. The publishing reference documents the check and what it does not establish.

Possibly related issues

Possibly related PRs

Merge Risk: Minimal · up to 6be1e

This change adds an offline compatibility check and documents it. It does not change production publishing behavior. No actionable merge-blocking risk was identified; hosted CI and the external review the author lists should still complete before promotion.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: validating application-owned release signers in the publishing flow. It uses the conventional fix(publishing) prefix and matches the stated objective of checking the s…
Description check Passed The description states the problem (the template rejects the application-owned release signer needed for its publisher switch), the intended change (validate that signer against the platform's exact r…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: validating application-owned release signers in the publishing flow. It uses the conventional fix(publishing) prefix and matches the stated objective of checking the signer against the platform's exact release rule. Nothing in the title describes work absent from the changeset.

Full details: Description check

Explanation

The description states the problem (the template rejects the application-owned release signer needed for its publisher switch), the intended change (validate that signer against the platform's exact release rule while keeping publication safeguards), and the scope boundary (the publisher switch and released-app verification are separate work, part of #289). It relates directly to the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8b071ce and 6be1e0b.

Files selected for processing: 2

  • docs/REFERENCE.md
  • scripts/platform-tenant-envelope.test.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 1

  • GitHub Check: CodeRabbit

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 6be1e0be8f16652148a45e4e40f3701c3c975953:

  • Native Platform Admissibility passed at this exact head. I read the real validator log: the signed tenant envelope passed 92 safety mutations, 36 subject controls and 53 producer controls; the network and VPA controls also passed. All 29 successful and 6 intentionally skipped head checks are settled, and every readable required gate passes. GitHub retains enforcement of the configured code-quality rule whose verdict has no readable API surface.
  • The authenticated current-head CodeRabbit summary is GREEN; all discussion, reviews and inline surfaces are complete, with zero unresolved threads or findings. No live writer holds the branch.
  • User evaluation: the actual validator accepts the minimal direct-publisher fixture only under the exact own-release rule, and rejects shared-only authorization, an explicit shared revision, execution environment overrides and branch publication. The diff adds offline compatibility checks and documentation; it does not switch the selected publisher or establish a signed, admitted or reconciled release. refactor(release): sign releases as this repository with the shared publish action #289 stays open for that work.

Promoting this preparation for the normal protected merge path.

@devantler
devantler marked this pull request as ready for review November 15, 2026 12:53
@devantler
devantler requested a review from a team as a code owner November 15, 2026 12:53
@devantler
devantler merged commit f9de50c into main Nov 15, 2026
35 checks passed
@devantler
devantler deleted the codex/own-release-289-2d5d branch November 15, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant