Skip to content

fix(release): prepare tenants for the shared publication lock - #302

Merged
devantler merged 1 commit into
mainfrom
codex/publisher-lock-compat-01a1e46f
Nov 16, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/publisher-lock-compat-01a1e46f

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Existing tenants validate publisher changes with the guard already on their default branch. Changing the publication lock before that guard understands it makes the update fail its own delivery checks.

What

The guard accepts both established publication locks while retaining its signing and permission checks. This prerequisite lets tenants adopt the compatible guard before the publisher changes in #300.

Part of #301

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The direct publisher identity check now accepts either the repository-specific publish- concurrency group or the publish-verified- concurrency group. The test verifies acceptance of the verified group and retains the rejection test for an unrelated group.

Possibly related issues

  • Issue 301 concerns the publisher serial queue and its validation. This change also prepares for the publisher change by accepting the verified publisher concurrency group.
Merge Risk: Minimal · up to 3cdfa

The guard now accepts both known publication lock names, which lets tenants adopt it before the publisher moves to the new lock. Existing signing and permission checks are retained, and the change is covered by a test. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change that matters most: the guard now accepts both publication locks, which prepares tenants for the shared lock. The summary's script change matches this, since the identity che…
Description check Passed The description explains why the change is needed. Tenants validate publisher changes with the guard already on their default branch, so the guard must accept the new publication lock first. It also s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change that matters most: the guard now accepts both publication locks, which prepares tenants for the shared lock. The summary's script change matches this, since the identity check now accepts the shared publish-verified concurrency group alongside the existing one. The title is specific and short, though it uses the 'fix(release)' prefix and does not name the script.

Full details: Description check

Explanation

The description explains why the change is needed. Tenants validate publisher changes with the guard already on their default branch, so the guard must accept the new publication lock first. It also states that the guard keeps its signing and permission checks, and it links the related work in #300 and #301. It relates directly to the changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cfa6554 and 3cdfa56.

Files selected for processing: 2

  • scripts/publish-pin-approved.sh
  • scripts/publish-pin-approved.test.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 1

  • GitHub Check: CodeRabbit
Additional comments: 1

scripts/publish-pin-approved.sh: 1

64-64: Data Integrity & Integration

Overlapping publish runs during the group migration need a check of the pinned publish action.

The guard accepts two concurrency groups. Jobs in different groups do not serialize, so an old publish- run and a new publish-verified- run can overlap during the migration. Whether those runs can write conflicting artifacts depends on the pinned publish action and its publisher workflow. Neither is available in this checkout, so the conflict cannot be confirmed or ruled out here.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 3cdfa56a54e444d30990ca696d2e7e16967dc981: the released guard refused the shared publication group before the change; the real guard now passes 47 controls, including the existing publisher, the shared lock, and refusal of an unrelated group. Caller contracts and all eight scaffold combinations/refusals pass, and shellcheck is clean. This exercises the guard users run; the default publisher workflow is unchanged.

Native CI is green, the exact-head CodeRabbit summary is green, all review surfaces are clear, and the branch contains current main. Code Quality setup is configured, with its managed head analysis unreadable; the normal protected merge will enforce that rule. This prerequisite keeps the subsequent publisher migration held until consumer base guards adopt compatibility.

@devantler
devantler marked this pull request as ready for review November 16, 2026 15:33
@devantler
devantler requested a review from a team as a code owner November 16, 2026 15:33
@devantler
devantler merged commit 81cf629 into main Nov 16, 2026
35 checks passed
@devantler
devantler deleted the codex/publisher-lock-compat-01a1e46f branch November 16, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant