You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(release): prepare tenants for the shared publication lock - #302
Existing tenants validate publisher changes with the guard already on their default branch. Changing the publication lock before that guard understands it makes the update fail its own delivery checks.
What
The guard accepts both established publication locks while retaining its signing and permission checks. This prerequisite lets tenants adopt the compatible guard before the publisher changes in #300.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
No actionable comments were generated in the recent review.
Walkthrough
The direct publisher identity check now accepts either the repository-specific publish- concurrency group or the publish-verified- concurrency group. The test verifies acceptance of the verified group and retains the rejection test for an unrelated group.
Possibly related issues
Issue 301 concerns the publisher serial queue and its validation. This change also prepares for the publisher change by accepting the verified publisher concurrency group.
Merge Risk: Minimal · up to 3cdfa
The guard now accepts both known publication lock names, which lets tenants adopt it before the publisher moves to the new lock. Existing signing and permission checks are retained, and the change is covered by a test. No concrete merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the change that matters most: the guard now accepts both publication locks, which prepares tenants for the shared lock. The summary's script change matches this, since the identity che…
Description check
The description explains why the change is needed. Tenants validate publisher changes with the guard already on their default branch, so the guard must accept the new publication lock first. It also s…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change that matters most: the guard now accepts both publication locks, which prepares tenants for the shared lock. The summary's script change matches this, since the identity check now accepts the shared publish-verified concurrency group alongside the existing one. The title is specific and short, though it uses the 'fix(release)' prefix and does not name the script.
Full details: Description check
Explanation
The description explains why the change is needed. Tenants validate publisher changes with the guard already on their default branch, so the guard must accept the new publication lock first. It also states that the guard keeps its signing and permission checks, and it links the related work in #300 and #301. It relates directly to the changeset.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between cfa6554 and 3cdfa56.
Files selected for processing: 2
scripts/publish-pin-approved.sh
scripts/publish-pin-approved.test.sh
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Recent review details
Context from checks skipped due to timeout: 1
GitHub Check: CodeRabbit
Additional comments: 1
scripts/publish-pin-approved.sh: 1
64-64: Data Integrity & Integration
Overlapping publish runs during the group migration need a check of the pinned publish action.
The guard accepts two concurrency groups. Jobs in different groups do not serialize, so an old publish- run and a new publish-verified- run can overlap during the migration. Whether those runs can write conflicting artifacts depends on the pinned publish action and its publisher workflow. Neither is available in this checkout, so the conflict cannot be confirmed or ruled out here.
Readiness at 3cdfa56a54e444d30990ca696d2e7e16967dc981: the released guard refused the shared publication group before the change; the real guard now passes 47 controls, including the existing publisher, the shared lock, and refusal of an unrelated group. Caller contracts and all eight scaffold combinations/refusals pass, and shellcheck is clean. This exercises the guard users run; the default publisher workflow is unchanged.
Native CI is green, the exact-head CodeRabbit summary is green, all review surfaces are clear, and the branch contains current main. Code Quality setup is configured, with its managed head analysis unreadable; the normal protected merge will enforce that rule. This prerequisite keeps the subsequent publisher migration held until consumer base guards adopt compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Existing tenants validate publisher changes with the guard already on their default branch. Changing the publication lock before that guard understands it makes the update fail its own delivery checks.
What
The guard accepts both established publication locks while retaining its signing and permission checks. This prerequisite lets tenants adopt the compatible guard before the publisher changes in #300.
Part of #301