Skip to content

Align own-release tag admission and verification grammars #6378

Closed
1 of 1 issue completed
Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

Description

The new composite publisher accepts semantic-version tags with build metadata, but the platform's own-release signer grammar rejects that suffix. An admitted release can therefore have a signing identity the consumer does not accept.

Steps to Reproduce

  1. Inspect publish-app admission at 3cab796adef97dcde0c55724866a0b19397aba39: it accepts v1.2.3+build.7, retains the full release tag in the signer identity, and removes build metadata from the OCI version.
  2. Compare the own-release subject grammar in the current Tenant graph. It ends after the optional prerelease and does not accept a build suffix.
  3. Compare the template's matching compatibility grammar at PR #300 head.

Expected Behavior

Every admitted release identity is accepted by the intended verification layers, or admission rejects unsupported release forms before publication.

Actual Behavior

The producer and consumer grammars differ. This is source-level evidence, not an induced publication or production failure. Reported finding.

Acceptance Criteria

  • Align the admitted tag grammar and all own-release verification layers through a reviewed producer or consumer change.
  • Use real admission and verification entrypoints to cover ordinary, prerelease and build-metadata tags, including malformed and cross-repository negative cases.
  • Preserve immutable tags, exact repository binding, finding/security gates and compatibility with valid existing releases.
  • Revalidate the template's compatibility reader and record publication/readback evidence separately from source merge.

Audience: release authors and operators of own-signed tenants. Size: Small to Medium depending on the chosen admission or verification change. Related: #6306 and platform-tenant-template#300. Part of devantler-tech/monorepo#5046. New intake is Backlog.

Activity

  1. added theissue type on Nov 15, 2026
  2. coderabbitai commented on Nov 15, 2026

    @coderabbitai
    Contributor
    ⚠️ Possible Duplicate Issue(s)


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

  3. moved this to 📥 Backlog in 🌊 Project Boardon Nov 15, 2026
  4. added a commit that references this issue on Nov 16, 2026
  5. devantler commented on Nov 16, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Producer side aligned and published. .github#949 merged at 02:23Z and shipped in v21.7.1 (tag commit 684b50681e3bd1fc6f3f48ad4c473073a051f5f1). The publisher now refuses a release tag carrying +BUILD metadata, so an admitted tag always fits the platform's own-release subject grammar, which has no build suffix. That grammar is unchanged.

    Checked against that head: the admission entrypoint refuses v1.2.3+abc with an instruction to drop the suffix, and admits v1.2.3 and v1.2.3-rc.1 past the tag check. The action's own test covers the malformed and cross-repository cases.

    Still open here: revalidating the template's compatibility reader and recording publication evidence. Both depend on platform-tenant-template#300 adopting v21.7.1, and that PR also waits on #6377 and template#301.

  6. devantler commented on Nov 16, 2026

    @devantler
    ContributorAuthor

    Closing: the producer side is aligned. The composite publish action refuses build metadata on release tags since v21.7.2 (actions/publish-app/admit.sh lines 52-64: a tag carrying + fails admission before anything is signed), so every admitted release identity is one the platform grammar accepts. Decision recorded in ADR 0019 (devantler-tech/monorepo#5095, epic devantler-tech/monorepo#5094).

    🤖 Generated with Claude Code

  7. moved this from 📥 Backlog to ✅ Done in 🌊 Project Boardon Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions