Repository navigation
feat(business-site): reconcile the public staging app behind its hold - #6174
Conversation
Turn on the business-site Tenant's own application and WebApp at the
already-verified v3.0.0 package. The platform-owned staging hold still
denies gateway traffic, so the site is not reachable yet.
- Admit exactly business-site.platform.devantler.tech for HTTPRoutes in
the business-site namespace; the catch-all denied every route there.
- Admit a tenant egress rule that is exactly {}: Cilium allows nothing
through it, and the package uses it to select egress default deny.
- Let the canonical source guard accept the source-only bootstrap shape
or both switches on together, never a half-enabled Tenant.
- Approve the moved Tenant ledger line and static-scan instance hash.
Part of #5247.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Local validation at head
One caveat: the bootstrap test ran while I briefly switched branches, so CI's run at this head is the authoritative one. 🤖 Generated with Claude Code |
The ownership-label replay pins each tenant family's exact Kyverno counts. The business-site route fixtures add one admitted and four refused routes, and the empty-egress fixture adds one admitted policy. Part of #5247. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
✅
|
Taking this PR to merge as the first step of devantler-tech/business-site#554 (portal.devantler.tech), followed by the hold removal and #6177. @coderabbitai review |
Action not completed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 6a7a6d0
- CodeRabbit: review limit at 2026-11-13T07:23:35Z on this PR ("Review limit reached", next included review in 42 minutes, about 08:06Z)
- Codex: usage limit at 2026-11-13T01:07:39Z on devantler-tech/.github#916 ("You have reached your Codex usage limits for code reviews"); lane DOWN, no completed review since 2026-11-12T04:47:01Z
- Cursor Bugbot: usage limit reached at 2026-11-12T22:36:57Z on #6151; no reply within 20 min of bugbot run on business-site#135 and #551 today
Verdict: no P0/P1 findings
v3.2.1 is the first business-site release with the two-host runtime and the package-owned public and portal routes. It is signed by the approved publish-app revision d8b5d0e9, as v3.0.0 was. - The binding and the Tenant digest are the unedited output of `bootstrap-tenant-source.sh --prepare-canonical-upgrade --tag v3.2.1`, run against the settled v3.0.0 binding from #6197 and a read-only production context. The preparation verified the release (cosign, tag v3.2.1, source 16cf60a0, run 43400872692) and the live v3.0.0 source (Ready, generation 3). - The Tenant keeps #6174's enabled flags; only its digest moves to sha256:eec71bcf…c66e4. - The rendered authorization surface and the static-scan baseline move only the business-site Tenant entry. Part of #6177 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

What
Turn on the business-site tenant's own application, behind the staging ingress hold that is already deployed. After this merges, the tenant reconciles its signed v3.0.0 package: the WebApp for
business-site.platform.devantler.tech, its network policy, disruption budget, SecretStore and the disclosure ExternalSecret. The platform-ownedbusiness-site-staging-holdstill denies gateway traffic to port 8080, so the site is not reachable yet. A follow-up PR removes the hold once the pods are healthy.Part of #5247 (and the live half of #4897). Epic: devantler-tech/monorepo#3939.
Changes
k8s/providers/hetzner/apps/business-site/tenant.yaml):webApp: trueandsource.reconcileApplication: true. Same digest and publisher as today.restrict-tenant-route-hostnames): admit exactlybusiness-site.platform.devantler.techin thebusiness-sitenamespace. Today the catch-all denies every route there, so KRO's HTTPRoute for the WebApp would be refused.devantler.tech, other tenants' names, wildcards and an empty hostname list stay refused (five new fixtures).restrict-tenant-network-policies): admit an egress rule that is exactly{}. The package's own policy usesegress: [{}]to select egress default deny. Cilium allows nothing through an empty rule (fix(policies): add-default-deny has generated an invalid CiliumNetworkPolicy into every namespace for ~101 days #3501, already noted in this test suite), but the check refused it because the rule names no destination. Running the published v3.0.0 package through Kyverno as the tenant service account gavefail: 1before this change andpassafter. A rule with onlytoPortsstill allows every peer on those ports and stays refused (egress-bare-l4). Ingress is unchanged.canonical-tenant-source.lib.shaccepts the source-only bootstrap shape or both switches on together. A half-enabled Tenant is still refused, and the bootstrap test now covers both shapes.test-business-staging-hold.shexpects the app on with the hold kept.Validation
kyverno test tests/restrict-tenant-route-hostnames: 23 passed.kyverno test tests/restrict-tenant-network-policies: 120 passed.scripts/tests/test-restrict-tenant-network-policies.shpasses withpass: 19, fail: 80.kyverno applyof all eight tenant/WebApp policies to the actual published v3.0.0 package (pulled anonymously from GHCR atsha256:7ec5b206…, members identical to source except the verified image pin), assystem:serviceaccount:business-site:business-site:pass: 4, fail: 0.go test ./scripts/validate-eks-ci-role-policy: 579 passed.go run ./scripts/validate-eks-ci-role-policy .shows no ledger difference, with the pinned kubectl v1.36.2.test-business-staging-hold.sh,test-canonical-source-bootstrap.sh,test-canonical-source-upgrade.sh,test-canonical-constructor-attribution.sh,test-tenant-source-discovery.sh,test-canonical-bootstrap-output.sh,test-tenant-webapp-boundary.sh,test-tenant-kro-pull-secret.sh,test-publish-workflow-canonical-approvals.sh,test-bootstrap-tenant-source.shandguard-consumer-discovery-conservation.sh: see the results comment.kubectl kustomize k8s/providers/hetzner/appsand…/infrastructurebuild with the intended Tenant and policy.After merge
Read-only checks: the Kustomization and WebApp are Ready, two pods are Ready with the disclosure file projected, the HTTPRoute is accepted, and gateway traffic is still refused while the hold stands.
Rollback: set both switches back to
false.reconcileApplicationis one-way in the graph (self || !oldSelf), so the practical rollback is the hold: it already blocks traffic, and it stays in place until the next PR.Not in scope: portal sign-in, customer intake, payments, and the
devantler.techcutover. Pages keeps servingdevantler.tech.🤖 Generated with Claude Code