Repository navigation
Conversation
The KHoist documentation source now selects the newest stable release of oci://ghcr.io/devantler-tech/khoist/manifests (ref.semver with the stable X.Y.Z filter) instead of a digest of the pre-rename data-product-controller/manifests artifact, which last received v6.0.1. It trusts only a workflow in devantler-tech/khoist's own .github/workflows/ on a release tag, in the Tenant graph's grammar (ADR 0019, monorepo ADR 0017). KHoist therefore leaves the shared-publisher approval machinery: its rows in the approved revisions, the identities and canonical approvals, its bootstrap publication, the matcher inventory, the report's consumer and artifact floors, the ledger's publish-matcher projection, and the khoist read grant and paths of the regeneration workflow. The regeneration contract test now also refuses a read grant for a repository that is no approved consumer. The authorization ledger approves the source's new fingerprint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…follows-release-tags Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codex review for tenant source trust and merge-order safety |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Blocked by #6433 The deployment lane remains held while production recovery is unresolved. This PR is still a draft at The merge order remains significant: #6415 and #6420 must land first. The KHoist publishing change originally linked as devantler-tech/khoist#625 was closed without merging; its replacement, devantler-tech/khoist#626, is open. Before this source can be deployed, verify a stable KHoist manifest release signed by its own publishing workflow and accepted by the proposed verification rule. Tried: read the current head, complete comment/review/thread connections, branch activity and deployment prerequisites. Codex reports no findings at this head and there are zero review threads. The current check rollup contains only a skipped CodeRabbit check; that does not establish passing required CI or pre-merge quality. Next: after verified recovery on #6433, finish the prerequisite platform and KHoist publication work, integrate the resulting base, and collect full validation, current-head review and quality evidence before removing this park. After protected merge, verify the deployed source selects the own-signed release and advances on the next release. |
Summary
Stacked on #6420. The KHoist documentation tenant follows KHoist's own signed release tags (monorepo ADR 0019, devantler-tech/monorepo#5094), so a KHoist release reaches it with no platform change, and KHoist leaves the shared-publisher approval machinery (ADR 0017).
The source (
k8s/providers/hetzner/apps/khoist-documentation/oci-repository.yaml)url:oci://ghcr.io/devantler-tech/khoist/manifests. The pinneddata-product-controller/manifestsartifact is the pre-rename name: it last received v6.0.1, and every KHoist release since publishes tokhoist/manifests, whosedocumentation/directory holds the same DNSEndpoint.ref:semver: ">=0.0.0"with the stable filter^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)$, checked every minute; no digest.verify: one identity,^https://github\.com/devantler-tech/khoist/\.github/workflows/[^/]+\.ya?ml@refs/tags/v<strict semver>$, the Tenant graph's grammar. The shared publisher, another repository, a branch or a non-release tag does not match../documentation, own service account,reconcile-exclude), its Role and RoleBinding. With feat(apps): keep tenant health out of the apps gate #6415 its health stays outsideapps.KHoist leaves the shared-publisher approvals
data-product-controllerrows removed frompublish-workflow-approved-revisions.tsv,.identities.tsvandpublish-workflow-canonical-approvals.tsv; its only bootstrap publication removed (publications: []); its line removed fromshared-publish-workflow-matchers.tsv.report-publish-workflow-signing-revisions.sh:data-product-controlleranddata-product-controller/manifestsleaveEXPECTED_CONSUMERS/EXPECTED_ARTIFACTS;consumer_github_repositoryloses thekhoistrename case.regenerate-publish-workflow-approved-revisions.yaml:khoistleaves the read token's repositories, and the documentation source leaves the moved-set andadd-pathsfences.scripts/validate-eks-ci-role-policy): the publish-matcher projection no longer coversdata-product-controller/manifests. Exactly one entry moves,source.toolkit.fluxcd.io/v1|OCIRepository|data-product-controller|khoist-documentation,f67fde24…→673e1243…: the URL, ref and subject above. Nothing is added or removed, and no RBAC changes.docs/TENANTS.mddescribes the moved source.Tests
test-khoist-documentation-tenant.shpins the new URL, ref, stable filter and exact own-release identity, and rejects the old URL, a digest ref, a missing or widened filter, the shared publisher, any first-party repository, and a second identity.test-regenerate-publish-workflow-approved-revisions.shnow also refuses a read-token repository that is no approved consumer (ablation:khoistkept in the read token); the renamed-consumer ablation, which has no subject left, is removed.publish_matcher_projection_test.goproves the retired matcher is no longer projected; fixture consumer sets in the matcher-writer, signing-report and canonical-approval tests dropdata-product-controller, and the canonical-approval identity table checks that the documentation source refuses the shared publisher and accepts a KHoist pre-release signer (selection, not the signer, keeps pre-releases out); the frozen legacy generator control expects four legacy consumers and none nameddata-product-controller.mainthen.devantler-tech/khoist/.github/workflows/cd.yaml@refs/tags/vX.Y.Z). Every stablekhoist/manifeststag today (up to 9.0.12) is signed by the shared publisher, so until then this source would refuse the newest release and stay not Ready.kubectl -n data-product-controller get ocirepository,kustomization khoist-documentationreports the own-signed release, and that a later release moves it by itself.Not in this PR: the KHoist controller chart
The controller chart (
k8s/bases/apps/data-product-controller/) stays digest-pinned here. Following its tags is not a small, clearly safe change:appshealth gate (feat(apps): keep tenant health out of the apps gate #6415 only frees Flux sources and Kustomizations), so a broken chart release would failappsand the merge-queue deploy;verify-data-product-rollout.shandtest-data-product-runtime-digests.shread those exact chart and image digests and prove them live;A design for it is in the session report and belongs in its own issue under devantler-tech/monorepo#5094.
Test plan
bash scripts/tests/test-khoist-documentation-tenant.sh— PASS (new mutations rejected)APPROVED_REVISIONS_ENFORCE=1 ./scripts/guard-publish-workflow-approved-revisions.sh— 4 consumer matchers agree./scripts/guard-shared-publish-workflow-pin.sh,./scripts/guard-oci-repository-verify.sh(9 in scope),./scripts/guard-consumer-discovery-conservation.sh— PASStest-publish-workflow-approved-revisions-guard.sh,test-write-publish-workflow-matchers.sh,test-publish-workflow-canonical-approvals.sh,test-tenant-source-discovery.sh,test-regenerate-publish-workflow-approved-revisions.sh(1 control + 59 ablations),test-shared-publish-workflow-pin-guard.sh,test-signing-report-publisher-families.sh,test-guard-oci-repository-verify.sh,test-guard-consumer-discovery-conservation.sh,test-publish-workflow-signing-revisions.sh,test-publish-workflow-signing-revision-resolvers.sh,test-frozen-legacy-publisher-release.sh,test-tenant-source-constructors.sh,test-production-authorization-rules.sh,test-isolated-chart-namespace-rules.sh(with an empty registry config; it 403s on stale local GHCR credentials on the base branch too),scripts/run-publication-generator-tests.sh— PASSgo test -count=1 ./scripts/validate-eks-ci-role-policy ./scripts/production-inputs/...— PASSshellcheck -xon every changed script — clean;kubectl kustomize k8s/providers/hetzner/appsandk8s/clusters/prod;ksail --config ksail.prod.yaml workload validate(985 files,khoist-documentation/oci-repository.yamlvalidated)bfe4ff0a) into this branch: the constructor, discovery and documentation tests, the conservation guard and its test, the approved-revisions, pin and OCIRepository guards and the ledger tests re-ran — PASS🤖 Generated with Claude Code