Skip to content

feat(khoist): follow KHoist's signed release tags for its documentation - #6426

Draft
devantler wants to merge 2 commits into
claude/tenant-follows-release-tagsfrom
claude/khoist-follows-release-tags
Draft

devantler wants to merge 2 commits into
claude/tenant-follows-release-tagsfrom
claude/khoist-follows-release-tags

Conversation

@devantler

@devantler devantler commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Stacked on #6420. The KHoist documentation tenant follows KHoist's own signed release tags (monorepo ADR 0019, devantler-tech/monorepo#5094), so a KHoist release reaches it with no platform change, and KHoist leaves the shared-publisher approval machinery (ADR 0017).

The source (k8s/providers/hetzner/apps/khoist-documentation/oci-repository.yaml)

  • url: oci://ghcr.io/devantler-tech/khoist/manifests. The pinned data-product-controller/manifests artifact is the pre-rename name: it last received v6.0.1, and every KHoist release since publishes to khoist/manifests, whose documentation/ directory holds the same DNSEndpoint.
  • ref: semver: ">=0.0.0" with the stable filter ^(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)\.(0|[1-9][0-9]*)$, checked every minute; no digest.
  • verify: one identity, ^https://github\.com/devantler-tech/khoist/\.github/workflows/[^/]+\.ya?ml@refs/tags/v<strict semver>$, the Tenant graph's grammar. The shared publisher, another repository, a branch or a non-release tag does not match.
  • Unchanged: the path-scoped, DNS-only Kustomization (./documentation, own service account, reconcile-exclude), its Role and RoleBinding. With feat(apps): keep tenant health out of the apps gate #6415 its health stays outside apps.

KHoist leaves the shared-publisher approvals

  • data-product-controller rows removed from publish-workflow-approved-revisions.tsv, .identities.tsv and publish-workflow-canonical-approvals.tsv; its only bootstrap publication removed (publications: []); its line removed from shared-publish-workflow-matchers.tsv.
  • report-publish-workflow-signing-revisions.sh: data-product-controller and data-product-controller/manifests leave EXPECTED_CONSUMERS / EXPECTED_ARTIFACTS; consumer_github_repository loses the khoist rename case.
  • regenerate-publish-workflow-approved-revisions.yaml: khoist leaves the read token's repositories, and the documentation source leaves the moved-set and add-paths fences.
  • Ledger (scripts/validate-eks-ci-role-policy): the publish-matcher projection no longer covers data-product-controller/manifests. Exactly one entry moves, source.toolkit.fluxcd.io/v1|OCIRepository|data-product-controller|khoist-documentation, f67fde24… → 673e1243…: the URL, ref and subject above. Nothing is added or removed, and no RBAC changes.
  • docs/TENANTS.md describes the moved source.

Tests

  • test-khoist-documentation-tenant.sh pins the new URL, ref, stable filter and exact own-release identity, and rejects the old URL, a digest ref, a missing or widened filter, the shared publisher, any first-party repository, and a second identity.
  • test-regenerate-publish-workflow-approved-revisions.sh now also refuses a read-token repository that is no approved consumer (ablation: khoist kept in the read token); the renamed-consumer ablation, which has no subject left, is removed.
  • publish_matcher_projection_test.go proves the retired matcher is no longer projected; fixture consumer sets in the matcher-writer, signing-report and canonical-approval tests drop data-product-controller, and the canonical-approval identity table checks that the documentation source refuses the shared publisher and accepts a KHoist pre-release signer (selection, not the signer, keeps pre-releases out); the frozen legacy generator control expects four legacy consumers and none named data-product-controller.

⚠️ Merge order

  1. feat(tenants): follow signed release tags instead of a digest pin #6420 (and feat(apps): keep tenant health out of the apps gate #6415 before it) merge first; rebase this onto main then.
  2. refactor(release): sign releases as this repository with the shared publish action khoist#625 merges and one KHoist release is cut and own-signed (signed as devantler-tech/khoist/.github/workflows/cd.yaml@refs/tags/vX.Y.Z). Every stable khoist/manifests tag today (up to 9.0.12) is signed by the shared publisher, so until then this source would refuse the newest release and stay not Ready.
  3. Merge this. Then check kubectl -n data-product-controller get ocirepository,kustomization khoist-documentation reports the own-signed release, and that a later release moves it by itself.

Not in this PR: the KHoist controller chart

The controller chart (k8s/bases/apps/data-product-controller/) stays digest-pinned here. Following its tags is not a small, clearly safe change:

  • the HelmRelease keeps the apps health gate (feat(apps): keep tenant health out of the apps gate #6415 only frees Flux sources and Kustomizations), so a broken chart release would fail apps and the merge-queue deploy;
  • the HelmRelease values and the platform's publisher-review and contract-probe Deployments pin the controller image by digest separately from the chart;
  • the prod deploy action's "Verify the deployed data product UI release" step, verify-data-product-rollout.sh and test-data-product-runtime-digests.sh read those exact chart and image digests and prove them live;
  • the platform's post-renderers patch chart internals (Deployment names, container index, HTTPRoute and NetworkPolicy names), so a chart refactor can fail the platform's render.

A design for it is in the session report and belongs in its own issue under devantler-tech/monorepo#5094.

Test plan

  • bash scripts/tests/test-khoist-documentation-tenant.sh — PASS (new mutations rejected)
  • APPROVED_REVISIONS_ENFORCE=1 ./scripts/guard-publish-workflow-approved-revisions.sh — 4 consumer matchers agree
  • ./scripts/guard-shared-publish-workflow-pin.sh, ./scripts/guard-oci-repository-verify.sh (9 in scope), ./scripts/guard-consumer-discovery-conservation.sh — PASS
  • test-publish-workflow-approved-revisions-guard.sh, test-write-publish-workflow-matchers.sh, test-publish-workflow-canonical-approvals.sh, test-tenant-source-discovery.sh, test-regenerate-publish-workflow-approved-revisions.sh (1 control + 59 ablations), test-shared-publish-workflow-pin-guard.sh, test-signing-report-publisher-families.sh, test-guard-oci-repository-verify.sh, test-guard-consumer-discovery-conservation.sh, test-publish-workflow-signing-revisions.sh, test-publish-workflow-signing-revision-resolvers.sh, test-frozen-legacy-publisher-release.sh, test-tenant-source-constructors.sh, test-production-authorization-rules.sh, test-isolated-chart-namespace-rules.sh (with an empty registry config; it 403s on stale local GHCR credentials on the base branch too), scripts/run-publication-generator-tests.sh — PASS
  • go test -count=1 ./scripts/validate-eks-ci-role-policy ./scripts/production-inputs/... — PASS
  • shellcheck -x on every changed script — clean; kubectl kustomize k8s/providers/hetzner/apps and k8s/clusters/prod; ksail --config ksail.prod.yaml workload validate (985 files, khoist-documentation/oci-repository.yaml validated)
  • After merging feat(tenants): follow signed release tags instead of a digest pin #6420's newer head (bfe4ff0a) into this branch: the constructor, discovery and documentation tests, the conservation guard and its test, the approved-revisions, pin and OCIRepository guards and the ledger tests re-ran — PASS
  • After step 2 and merge: the source reports the own-signed release Ready, and the next KHoist release moves it with no platform change

🤖 Generated with Claude Code

devantler and others added 2 commits November 16, 2026 13:22
The KHoist documentation source now selects the newest stable release of
oci://ghcr.io/devantler-tech/khoist/manifests (ref.semver with the stable
X.Y.Z filter) instead of a digest of the pre-rename
data-product-controller/manifests artifact, which last received v6.0.1. It
trusts only a workflow in devantler-tech/khoist's own .github/workflows/ on a
release tag, in the Tenant graph's grammar (ADR 0019, monorepo ADR 0017).

KHoist therefore leaves the shared-publisher approval machinery: its rows in
the approved revisions, the identities and canonical approvals, its
bootstrap publication, the matcher inventory, the report's consumer and
artifact floors, the ledger's publish-matcher projection, and the khoist
read grant and paths of the regeneration workflow. The regeneration contract
test now also refuses a read grant for a repository that is no approved
consumer. The authorization ledger approves the source's new fingerprint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…follows-release-tags

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for tenant source trust and merge-order safety

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T12:38:12.817188Z 000d41f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 000d41f788

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocked by #6433

The deployment lane remains held while production recovery is unresolved. This PR is still a draft at 000d41f78864d75489193afe3e32afeb670c0488, outside the merge queue, with auto-merge disabled.

The merge order remains significant: #6415 and #6420 must land first. The KHoist publishing change originally linked as devantler-tech/khoist#625 was closed without merging; its replacement, devantler-tech/khoist#626, is open. Before this source can be deployed, verify a stable KHoist manifest release signed by its own publishing workflow and accepted by the proposed verification rule.

Tried: read the current head, complete comment/review/thread connections, branch activity and deployment prerequisites. Codex reports no findings at this head and there are zero review threads. The current check rollup contains only a skipped CodeRabbit check; that does not establish passing required CI or pre-merge quality.

Next: after verified recovery on #6433, finish the prerequisite platform and KHoist publication work, integrate the resulting base, and collect full validation, current-head review and quality evidence before removing this park. After protected merge, verify the deployed source selects the own-signed release and advances on the next release.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🫴 Ready

Development

Successfully merging this pull request may close these issues.

1 participant